[SERVER-42399] max_time_ms.js test should always disable failpoints if an exception is thrown Created: 24/Jul/19 Updated: 29/Oct/23 Resolved: 13/Sep/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Querying |
| Affects Version/s: | None |
| Fix Version/s: | 4.2.1, 4.3.1 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | William Schultz (Inactive) | Assignee: | Arun Banala |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | greenerbuild, query-44-grooming | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Backport Requested: |
v4.2
|
||||||||
| Participants: | |||||||||
| Linked BF Score: | 3 | ||||||||
| Description |
|
The max_time_ms.js test utilizes the maxTimeNeverTimeOut failpoint. This failpoint overrides a maxTimeMS deadline set by any command, allowing them to run indefinitely. If there is an assertion failure in the test after the failpoint is enabled, we may run subsequent tests in a test fixture without disabling the failpoint. This can cause issues (i.e. hangs) in other tests that expect a command to time out with a maxTimeMS expiration. We should make the test robust to exceptions by making sure that we always disable the failpoint in the case of an error. |
| Comments |
| Comment by Githook User [ 13/Sep/19 ] |
|
Author: {'name': 'Arun Banala', 'email': 'arun.banala@10gen.com'}Message: (cherry picked from commit 8f02ac7fa2927ec6fe042432644c54ad1ec92fc8) |
| Comment by Githook User [ 13/Sep/19 ] |
|
Author: {'name': 'Arun Banala', 'email': 'arun.banala@10gen.com'}Message: |