[SERVER-42492] Attach DiagnosticInfo on long mongo::ConditionVariable::wait() Created: 29/Jul/19  Updated: 29/Oct/23  Resolved: 20/Aug/19

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Bug Priority: Major - P3
Reporter: Benjamin Caimano (Inactive) Assignee: Rahul Sundararaman (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Service Arch 2019-08-26
Participants:
Linked BF Score: 0

 Description   

We should modify ConditionVariable::wait() (and sibling functions) to attach a DiagnosticInfo to Client similar to how we modified Mutex::lock() for contended locking after 100ms. This will allow us to identify Condvars where they are able to acquire the underlying lock but their condition is not satisfied.



 Comments   
Comment by Githook User [ 31/Oct/19 ]

Author:

{'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com', 'name': 'Ben Caimano'}

Message: SERVER-41357 SERVER-41360 SERVER-43324 Add Mutex, BasicLockableAdaptor, and DiagnosticInfo

This commit backports Mutex, BasicLockableAdaptor, and DiagnosticInfo to
v4.2. These pieces came in completely in various interleaved commits.
The constituent commits partially included in this backport are listed
below. The majority of these commits are part of the "Improved
Diagnostics for Latches" epic.

Mutex:

BasicLockableAdaptor:

DiagnosticInfo:

Note that while this commit adds these pieces and integrates them into
the mongo-server codebase, it does not convert existing stdx::mutex
construction. It also does not include the updates to Interruptible that
were done as part of "Improved Diagnostics for Latches".
Branch: v4.2
https://github.com/mongodb/mongo/commit/3a05e4ce75cd03b09b52ec5943e1801c6d91279b

Comment by Githook User [ 21/Aug/19 ]

Author:

{'name': 'Gregory Wlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'username': 'GWlodarek'}

Message: SERVER-42492 Fix lint
Branch: master
https://github.com/mongodb/mongo/commit/f9aa31e3da8a8f4b85a0eb4be7ae5654776b816a

Comment by Githook User [ 20/Aug/19 ]

Author:

{'username': 'rsbballguy', 'email': 'rahul.sundararaman@10gen.com', 'name': 'Rahul Sundararaman'}

Message: SERVER-42492 Attach DiagnosticInfo on long mongo::ConditionVariable::wait()
Branch: master
https://github.com/mongodb/mongo/commit/18a3e230c7d1d1cbe3e54e584c7dcc8c9052b422

Generated at Thu Feb 08 05:00:38 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.