[SERVER-42622] resmoke.py doesn't attempt to tear the fixture down if setting it up raises an exception Created: 04/Aug/19  Updated: 29/Oct/23  Resolved: 06/Aug/19

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 4.2.1, 4.3.1

Type: Bug Priority: Major - P3
Reporter: Max Hirschhorn Assignee: Max Hirschhorn
Resolution: Fixed Votes: 0
Labels: tig-resmoke
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
is related to SERVER-40592 Uncaught exception in resmoke.py job ... Closed
is related to SERVER-42356 teardown(finished=True) isn't ever ca... Closed
is related to SERVER-28940 Make resmoke fixture setup/teardown t... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.2
Sprint: STM 2019-08-12
Participants:
Story Points: 1

 Description   

Discovered this issue while investigating SERVER-42356. It is yet another way for close() to never be called on the FixtureLogger. Job.teardown_fixture() won't be called if Job.setup_fixture() raises an exception.



 Comments   
Comment by Githook User [ 13/Aug/19 ]

Author:

{'name': 'Max Hirschhorn', 'username': 'visemet', 'email': 'max.hirschhorn@mongodb.com'}

Message: SERVER-42622 Call teardown_fixture() even if setup_fixture() errors.

(cherry picked from commit 45b43da30b348b6eb471e9a5c5e4b33550fc53ff)
Branch: v4.2
https://github.com/mongodb/mongo/commit/cd543c54468d7e0a601a35b0a7ecc39d98bf43a6

Comment by Githook User [ 06/Aug/19 ]

Author:

{'name': 'Max Hirschhorn', 'email': 'max.hirschhorn@mongodb.com', 'username': 'visemet'}

Message: SERVER-42622 Call teardown_fixture() even if setup_fixture() errors.
Branch: master
https://github.com/mongodb/mongo/commit/45b43da30b348b6eb471e9a5c5e4b33550fc53ff

Generated at Thu Feb 08 05:00:59 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.