[SERVER-42767] Improve logging in ReplSetTest.stopSet Created: 12/Aug/19  Updated: 29/Oct/23  Resolved: 04/Sep/19

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.0.13, 4.2.1, 4.3.1

Type: Improvement Priority: Major - P3
Reporter: William Schultz (Inactive) Assignee: William Schultz (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.2, v4.0
Sprint: Repl 2019-08-26, Repl 2019-09-09
Participants:
Linked BF Score: 12

 Description   

We have relatively sparse logging inside ReplSetTest.stopSet, which can make it hard to understand which parts of the function are currently running or whether certain branches were taken at all. We could add log messages to indicate the following information:



 Comments   
Comment by Githook User [ 26/Sep/19 ]

Author:

{'username': 'will62794', 'email': 'william.schultz@mongodb.com', 'name': 'William Schultz'}

Message: SERVER-42767 Improve logging in ReplSetTest.stopSet

(cherry picked from commit db9ca6771bbd20086fd5b824ccb4dee1a29a0e39)
Branch: v4.0
https://github.com/mongodb/mongo/commit/4096776ae66656894ec9f7045f7bc7e4afdb17f3

Comment by Githook User [ 25/Sep/19 ]

Author:

{'username': 'will62794', 'email': 'william.schultz@mongodb.com', 'name': 'William Schultz'}

Message: SERVER-42767 Improve logging in ReplSetTest.stopSet

(cherry picked from commit db9ca6771bbd20086fd5b824ccb4dee1a29a0e39)
Branch: v4.2
https://github.com/mongodb/mongo/commit/56cd56baabef1cc06315a6269d8e58c5f35f144e

Comment by Githook User [ 04/Sep/19 ]

Author:

{'username': 'will62794', 'email': 'william.schultz@mongodb.com', 'name': 'William Schultz'}

Message: SERVER-42767 Improve logging in ReplSetTest.stopSet
Branch: master
https://github.com/mongodb/mongo/commit/db9ca6771bbd20086fd5b824ccb4dee1a29a0e39

Comment by William Schultz (Inactive) [ 03/Sep/19 ]

Code review url: https://mongodbcr.appspot.com/506830001/

Comment by William Schultz (Inactive) [ 12/Aug/19 ]

I found BF-14328 a bit trickier to debug since I could not easily tell which parts of ReplSetTest.stopSet did or did not run. For example, whether we ran consistency checks or not.

Generated at Thu Feb 08 05:01:22 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.