[SERVER-42790] Change ConnectionPool's kDiagnosticLogLevel from 3 to 4 Created: 13/Aug/19  Updated: 29/Oct/23  Resolved: 30/Sep/19

Status: Closed
Project: Core Server
Component/s: Networking
Affects Version/s: None
Fix Version/s: 4.3.1, 4.2.2

Type: Task Priority: Major - P3
Reporter: Esha Maharishi (Inactive) Assignee: Benjamin Caimano (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.2
Sprint: Sharding 2019-08-26, Sharding 2019-10-07
Participants:

 Description   

These log lines have been really verbose, particularly in sharding suites where you have a lot of nodes. Could we reduce the log level from 3 to 4?

Since it's such an easy change, I'm attaching a cr. When this is triaged, if it's decided that this log level change is fine, it would be great if someone could LGTM the cr and I will immediately push the change

CC ben.caimano



 Comments   
Comment by Githook User [ 11/Nov/19 ]

Author:

{'name': 'Ben Caimano', 'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com'}

Message: SERVER-42790 Change ConnectionPool's kDiagnosticLogLevel from 3 to 4
Branch: v4.2
https://github.com/mongodb/mongo/commit/9ee9ea203e1ab143a2e04cbf5021e7ec4b50ad15

Comment by Esha Maharishi (Inactive) [ 30/Sep/19 ]

Closing but assigned the backport to v4.2 to ben.caimano, since the backport was reverted.

Comment by Githook User [ 23/Sep/19 ]

Author:

{'username': 'pvselvan', 'email': 'pavithra.vetriselvan@mongodb.com', 'name': 'Pavithra Vetriselvan'}

Message: Revert "SERVER-42790 SERVER-42930 ConnectionPool controller updates must batch across hosts"

This reverts commit e9f5360ba5fba5598e2556816a9d7d818ab586c7.
Branch: v4.2
https://github.com/mongodb/mongo/commit/28a50ae351071acdf18745c0f3bb54c84485d3ba

Comment by Benjamin Caimano (Inactive) [ 19/Sep/19 ]

Backported this to make SERVER-42930 backport smoother.

Comment by Githook User [ 19/Sep/19 ]

Author:

{'name': 'Ben Caimano', 'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com'}

Message: SERVER-42790 SERVER-42930 ConnectionPool controller updates must batch across hosts
Branch: v4.2
https://github.com/mongodb/mongo/commit/e9f5360ba5fba5598e2556816a9d7d818ab586c7

Comment by Githook User [ 13/Aug/19 ]

Author:

{'name': 'Esha Maharishi', 'email': 'esha.maharishi@mongodb.com', 'username': 'EshaMaharishi'}

Message: SERVER-42790 Change ConnectionPool's kDiagnosticLogLevel from 3 to 4
Branch: master
https://github.com/mongodb/mongo/commit/aea4be527bf018e905e0da966c87782624924ecf

Comment by Benjamin Caimano (Inactive) [ 13/Aug/19 ]

Glad to see that bucketing this served its purpose, it was meant so these lines could be hidden unless in a test where it was really important to see them.

Generated at Thu Feb 08 05:01:26 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.