[SERVER-42792] CollectionShardingState::_getMetadataWithVersionCheckAt should return boost::none if the client did not send a shardVersion for the ns Created: 13/Aug/19 Updated: 29/Oct/23 Resolved: 13/Aug/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.1 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Esha Maharishi (Inactive) | Assignee: | Esha Maharishi (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Sharding 2019-08-26 |
| Participants: |
| Description |
|
This is just code cleanup. Currently CollectionShardingState::_getMetadataWithVersionCheckAt returns an "UnshardedCollection" ScopedCollectionMetadata, but it should just return boost::none, since its caller (getOrphansFilter) converts a boost::none return value into an "UnshardedCollection" ScopedCollectionMetadata anyway. |
| Comments |
| Comment by Githook User [ 13/Aug/19 ] |
|
Author: {'name': 'Esha Maharishi', 'email': 'esha.maharishi@mongodb.com', 'username': 'EshaMaharishi'}Message: |