[SERVER-42806] Fix naming and return types in `src/mongo/base/backtrace_visibility_test.cpp` Created: 13/Aug/19  Updated: 29/Oct/23  Resolved: 01/Oct/19

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Improvement Priority: Major - P3
Reporter: ADAM Martin (Inactive) Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Dev Tools 2019-10-07
Participants:

 Description   

We don't use snake_case_function_names.  The functions here can also return by value, instead of assigning to an out parameter.



 Comments   
Comment by Githook User [ 30/Sep/19 ]

Author:

{'name': 'Billy Donahue', 'username': 'BillyDonahue', 'email': 'billy.donahue@mongodb.com'}

Message: SERVER-42806 move base/backtrace test stuff to util/stacktrace_*
Branch: master
https://github.com/mongodb/mongo/commit/9e17dc2559f3e2d15673bbb1a448af047f657a1d

Comment by Billy Donahue [ 21/Sep/19 ]

https://mongodbcr.appspot.com/511070001/

Comment by Billy Donahue [ 21/Sep/19 ]

I do weakly disagree with this statement, though, ADAM:
"The functions here can also return by value, instead of assigning to an out parameter."
That's technically true, but I kind of like the idea that we're just sort of listening in on these functions as they proceed about their business, like passing a logging steam along. Maybe we should be passing an ostream& instead of string&. Then it wouldn't look so weird.

Comment by Billy Donahue [ 21/Sep/19 ]

this test should move to util/ where stacktrace is.
It should also be renamed from backtrace to stacktrace.
And this file is not a test. It's support apparatus for a test. So it should be renamed to reflect that too.

Generated at Thu Feb 08 05:01:28 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.