[SERVER-42806] Fix naming and return types in `src/mongo/base/backtrace_visibility_test.cpp` Created: 13/Aug/19 Updated: 29/Oct/23 Resolved: 01/Oct/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.1 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | ADAM Martin (Inactive) | Assignee: | Billy Donahue |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Dev Tools 2019-10-07 |
| Participants: |
| Description |
|
We don't use snake_case_function_names. The functions here can also return by value, instead of assigning to an out parameter. |
| Comments |
| Comment by Githook User [ 30/Sep/19 ] |
|
Author: {'name': 'Billy Donahue', 'username': 'BillyDonahue', 'email': 'billy.donahue@mongodb.com'}Message: |
| Comment by Billy Donahue [ 21/Sep/19 ] |
| Comment by Billy Donahue [ 21/Sep/19 ] |
|
I do weakly disagree with this statement, though, ADAM: |
| Comment by Billy Donahue [ 21/Sep/19 ] |
|
this test should move to util/ where stacktrace is. |