[SERVER-42836] Make sort key generation for WorkingSetMembers use Document instead of BSONObj Created: 15/Aug/19  Updated: 29/Oct/23  Resolved: 15/Oct/19

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Task Priority: Major - P3
Reporter: David Storch Assignee: Justin Seyster
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Problem/Incident
Backwards Compatibility: Fully Compatible
Sprint: Query 2019-09-09, Query 2019-09-23, Query 2019-10-07, Query 2019-10-21
Participants:
Linked BF Score: 0

 Description   

This will also allow us to delete the SortKeyGenerator::Metadata type.



 Comments   
Comment by Githook User [ 21/Oct/19 ]

Author:

{'name': 'Justin Seyster', 'username': 'jseyster', 'email': 'justin.seyster@mongodb.com'}

Message: SERVER-42836 Count bytes in _totalDataSizeBytes after adding to Sorter

Before this patch, the bytes get added before we add to the Sorter,
even though there is still a possibility that Sorter::add() will use
up the rest of its memory limit and throw.
Branch: master
https://github.com/mongodb/mongo/commit/babc552483a0f8a2fff4c20354089b78da14baeb

Comment by Githook User [ 15/Oct/19 ]

Author:

{'username': 'jseyster', 'email': 'justin.seyster@mongodb.com', 'name': 'Justin Seyster'}

Message: SERVER-42836 Fast path for sort key generation of WorkingSetMembers

Includes a small change to external_sort_find.js, which was failing
when this change was initially submitted.

This reverts commit 72d8bff5f619ebdcb9904f5978ac14b2f53ea686.
Branch: master
https://github.com/mongodb/mongo/commit/0b80f48b436a14cdfc6d05eb4108aa4e796565ce

Comment by Githook User [ 08/Oct/19 ]

Author:

{'username': 'jseyster', 'email': 'justin.seyster@mongodb.com', 'name': 'Justin Seyster'}

Message: Revert "SERVER-42836 Fast path for sort key generation of WorkingSetMembers"

Reverting due to failure in external_sort_find.js.

This reverts commit d22968677a25ccd587fdadc7106b181780393736.
Branch: master
https://github.com/mongodb/mongo/commit/72d8bff5f619ebdcb9904f5978ac14b2f53ea686

Comment by Githook User [ 08/Oct/19 ]

Author:

{'username': 'jseyster', 'email': 'justin.seyster@mongodb.com', 'name': 'Justin Seyster'}

Message: SERVER-42836 Fast path for sort key generation of WorkingSetMembers

(Also includes a comment fixup in document_value_test.cpp that was
intended for a previous commit.)
Branch: master
https://github.com/mongodb/mongo/commit/d22968677a25ccd587fdadc7106b181780393736

Comment by Justin Seyster [ 01/Oct/19 ]

Code review url: https://mongodbcr.appspot.com/495570004/

Comment by Justin Seyster [ 09/Sep/19 ]

An important goal of this ticket is to make sure that sort in find and agg both use the "fast path" key extraction from Document when they do not need an array traversal.

Generated at Thu Feb 08 05:01:33 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.