[SERVER-42839] Make storage_engine.h functions that throw / fassert / invariant pure virtual functions Created: 15/Aug/19  Updated: 29/Oct/23  Resolved: 27/Sep/19

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Improvement Priority: Major - P3
Reporter: Dianna Hohensee (Inactive) Assignee: Evgeni Dobranov
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2019-10-07
Participants:

 Description   

It doesn't make sense to throw/fassert/invariant in functions declared in storage_engine.h anymore, because storage_engine_impl.h always overrides them.

For example in storage_engine.h,
https://github.com/mongodb/mongo/blob/c0ca6049bad1bf918e46d83cddab134b7441abf7/src/mongo/db/storage/storage_engine.h#L398-L423

and correspondingly in storage_engine_impl.h
https://github.com/mongodb/mongo/blob/c0ca6049bad1bf918e46d83cddab134b7441abf7/src/mongo/db/storage/storage_engine_impl.h#L136-L140



 Comments   
Comment by Githook User [ 26/Sep/19 ]

Author:

{'name': 'Evgeni Dobranov', 'username': 'edobranov', 'email': 'evgeni.dobranov@mongodb.com'}

Message: SERVER-42839 Make storage_engine.h functions pure virtual
Branch: master
https://github.com/mongodb/mongo/commit/5a0e08e83231cfa07aa1d00098d0712f3c2f8ab7

Generated at Thu Feb 08 05:01:34 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.