[SERVER-42908] Add ErrorCodes to retryable errors to match drivers Created: 19/Aug/19  Updated: 29/Oct/23  Resolved: 09/Sep/19

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.2.1, 4.3.1, 4.0.20

Type: Improvement Priority: Major - P3
Reporter: Benjamin Caimano (Inactive) Assignee: Benjamin Caimano (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.2, v4.0
Sprint: Service Arch 2019-08-26, Service Arch 2019-09-09
Participants:
Linked BF Score: 10

 Description   

There is a very nice drivers spec that mostly agrees with RemoteCommandRetryScheduler::kAllRetriableErrors but for SocketException and the class of ShutdownErrors. We should make our list a superset of those errors.



 Comments   
Comment by Githook User [ 08/Jul/20 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@mongodb.com', 'username': 'bcaimano'}

Message: SERVER-42908 Add ErrorCodes to retryable errors to match drivers

Changes to src/mongo/base/error_codes.yml in v4.3 are replicated on
src/mongo/base/error_codes.err for v4.2.
(cherry picked from commit 0f16c5fc452d16c5a92e43e9fdd96f3822f05271)
(cherry picked from commit 0d9e6dbfdd8aea3cd110bfe1a67bbee31d5a8a3b)
Branch: v4.0
https://github.com/mongodb/mongo/commit/658fccc18c525d0d9ad7aaa32a08b692b19bf0dd

Comment by Esha Maharishi (Inactive) [ 22/Jun/20 ]

Requesting backport to 4.0 since backporting SERVER-47799 makes most sense if this is also backported: SERVER-47799 made mongos mark a host as failed in the RSM on hearing back InterruptedAtShutdown, which is most useful if mongos also treats InterruptedAtShutdown as an internally retriable error.

We will try to backport both, but if one or both is too cumbersome because 4.0 is too different from 4.2, we'll decline both backports.

Comment by Githook User [ 15/Oct/19 ]

Author:

{'name': 'Ben Caimano', 'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com'}

Message: SERVER-42908 Add ErrorCodes to retryable errors to match drivers

Changes to src/mongo/base/error_codes.yml in v4.3 are replicated on
src/mongo/base/error_codes.err for v4.2.
(cherry picked from commit 0f16c5fc452d16c5a92e43e9fdd96f3822f05271)
Branch: v4.2
https://github.com/mongodb/mongo/commit/0d9e6dbfdd8aea3cd110bfe1a67bbee31d5a8a3b

Comment by Githook User [ 09/Sep/19 ]

Author:

{'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com', 'name': 'Ben Caimano'}

Message: SERVER-42908 Add ErrorCodes to retryable errors to match drivers
Branch: master
https://github.com/mongodb/mongo/commit/0f16c5fc452d16c5a92e43e9fdd96f3822f05271

Generated at Thu Feb 08 05:01:44 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.