[SERVER-42958] Don't construct unused error Status in MultiIndexBlock::insert Created: 21/Aug/19  Updated: 29/Oct/23  Resolved: 21/Aug/19

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Improvement Priority: Major - P3
Reporter: Louis Williams Assignee: Louis Williams
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2019-08-26
Participants:

 Description   

Constructing this unused status is really expensive, because it's marked cold, and ends up messing with branch prediction. We should just construct a Status::OK.



 Comments   
Comment by Githook User [ 21/Aug/19 ]

Author:

{'name': 'Louis Williams', 'email': 'louis.williams@mongodb.com', 'username': 'louiswilliams'}

Message: SERVER-42958 Don't construct unused error Status in MultiIndexBlock::insert
Branch: master
https://github.com/mongodb/mongo/commit/5250df3ea62783b2c3cdf2d638258680b6f64fc0

Generated at Thu Feb 08 05:01:53 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.