[SERVER-42962] remove Error Status construction for every applyOp'd op Created: 21/Aug/19  Updated: 29/Oct/23  Resolved: 12/Sep/19

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Task Priority: Major - P3
Reporter: Eric Milkie Assignee: Evgeni Dobranov
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-43924 remove Error Status construction from... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2019-09-09, Execution Team 2019-09-23
Participants:

 Description   

https://github.com/mongodb/mongo/blob/cb65f662017c8661cec0f4e07d08b829a1a67ad6/src/mongo/db/repl/apply_ops.cpp#L129

This line of code is hinted as Cold to the compiler, which can affect branch prediction and performance. We should refactor to remove this line or replace it with one that uses Status::OK, which is not hinted as Cold.



 Comments   
Comment by Githook User [ 12/Sep/19 ]

Author:

{'name': 'Evgeni Dobranov', 'username': 'edobranov', 'email': 'evgeni.dobranov@mongodb.com'}

Message: SERVER-42962 Remove construction of Status with ErrorCodes::Error in _applyOps
Branch: master
https://github.com/mongodb/mongo/commit/e3a8d37b8775d90f85cb64f3630cb547a886baa1

Generated at Thu Feb 08 05:01:54 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.