[SERVER-42998] Make multiSyncApply non-configurable Created: 23/Aug/19 Updated: 29/Oct/23 Resolved: 10/Oct/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.1 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | A. Jesse Jiryu Davis | Assignee: | Mihai Andrei |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Repl 2019-10-07, Repl 2019-10-21 |
| Participants: |
| Description |
|
SyncTail::oplogApplication takes a callback function, which is normally the free function multiSyncApply. This callback takes a pointer to a SyncTail and calls methods on it. This is the most tangled part of the control flow. The only reason to make this function a configurable callback is so tests can override it with a no-op function in order to disable oplog application. This could be done more simply with a configuration option or by subclassing, leaving the main codepath more clear. Convert multiSyncApply (which will have been renamed to applyGroup and moved into OplogApplier) from a free function to a method of OplogApplier. |
| Comments |
| Comment by Githook User [ 10/Oct/19 ] |
|
Author: {'name': 'Mihai Andrei', 'email': 'mihai.andrei@mongodb.com'}Message: |