[SERVER-43000] Unify classes that hold lists of oplog entries Created: 23/Aug/19 Updated: 29/Oct/23 Resolved: 22/Nov/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.3 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | A. Jesse Jiryu Davis | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Repl 2019-12-02 |
| Participants: |
| Description |
|
Today, oplog entries are moved among several lists on their way from OplogFetcher to SyncTail::multiApply:
The number of steps in the pipeline is probably not a performance problem, but the data flow is confusing, and there are many implementations of the same basic idea of a list of oplog entries. Rename OpQueue to OplogBatch, and remove all typedefs of vector<OplogEntry>, they obscure more than they help. Rename OpQueueBatcher to OplogBatcher. The only remaining list of oplog entries is OplogEntryBatch (renamed OplogEntryOrGroupedInserts in Step 10), which holds one oplog entry or a list of insert oplog entries. This class is useful enough to keep. |
| Comments |
| Comment by Githook User [ 22/Nov/19 ] |
|
Author: {'email': 'jesse@mongodb.com', 'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis'}Message: |
| Comment by Githook User [ 21/Nov/19 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 21/Nov/19 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: |