[SERVER-43040] Remove the unit test used only variation of LockerImpl::lockGlobal that passes in a nullptr for opCtx Created: 26/Aug/19  Updated: 29/Oct/23  Resolved: 01/Jul/20

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Improvement Priority: Major - P3
Reporter: Dianna Hohensee (Inactive) Assignee: Bynn Lee
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2020-07-13
Participants:

 Description   
  1. A variation of LockerImpl::lockGlobal passes in a nullptr for opCtx and is only used in unit tests. All of the production callers use a variation of LockerImpl::lockGlobal that takes a real opCtx.

This would requiring setting up an opCtx for the locking unit tests. It is trivial to add it to d_concurrency_test.cpp unit tests as opCtx is already available in other unit tests using the same test fixture. lock_state_test.cpp, however, just uses ServiceContextTest, which does not set up an opCtx: we would have to add an opCtx to the test fixture.



 Comments   
Comment by Githook User [ 01/Jul/20 ]

Author:

{'name': 'Bynn Lee', 'email': 'bynn.lee@mongodb.com', 'username': 'bynn'}

Message: SERVER-43040 Remove the unit test used only variation of LockerImpl::lockGlobal that passes in a nullptr for opCtx
Branch: master
https://github.com/mongodb/mongo/commit/e14ec02403b4119b17bf013aa257a5eafeb35073

Generated at Thu Feb 08 05:02:06 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.