[SERVER-43062] "clang_format.py format-my" dies on git-deleted files Created: 28/Aug/19  Updated: 29/Oct/23  Resolved: 09/Sep/19

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: Mathew Robinson (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Dev Tools 2019-09-23
Participants:

 Description   

the script dies as it tries to format a file that has been "git rm"-ed.

In this client, I've removed src/mongo/util/stacktrace_unwind.cpp.

(venv3) billy@billydev:~/dev/mongodb/mongo$ buildscripts/clang_format.py format-my
adding module: enterprise
adding module: ninja
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/opt/mongodbtoolchain/stow/python3-v3.8CA/lib/python3.7/threading.py", line 917, in _bootstrap_inner
    self.run()
  File "/opt/mongodbtoolchain/stow/python3-v3.8CA/lib/python3.7/threading.py", line 865, in run
    self._target(*self._args, **self._kwargs)
  File "/home/billy/dev/mongodb/mongo/buildscripts/linter/parallel.py", line 37, in worker
    ret = func(item)
  File "buildscripts/clang_format.py", line 281, in format
    if self._lint(file_name, print_diff=False):
  File "buildscripts/clang_format.py", line 247, in _lint
    with open(file_name, 'rb') as original_text:
FileNotFoundError: [Errno 2] No such file or directory: '/home/billy/dev/mongodb/mongo/src/mongo/util/stacktrace_unwind.cpp'



 Comments   
Comment by Githook User [ 09/Sep/19 ]

Author:

{'username': 'chasinglogic', 'email': 'mathew.robinson@mongodb.com', 'name': 'Mathew Robinson'}

Message: SERVER-43062 Verify files exist when running format-my
Branch: master
https://github.com/mongodb/mongo/commit/a15f14d7e8b73b0996fe382c679e5b7f3636250d

Comment by Billy Donahue [ 28/Aug/19 ]

As a short-term workaround, I touch the rm'ed file and remove it again after clang-format.py runs.

Generated at Thu Feb 08 05:02:09 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.