[SERVER-43100] Remove CoordinateCommitReturnsNoneIfCoordinatorWasRemoved unit test Created: 30/Aug/19  Updated: 29/Oct/23  Resolved: 16/Sep/19

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 4.3.1, 4.2.7

Type: Bug Priority: Major - P3
Reporter: Esha Maharishi (Inactive) Assignee: Cheahuychou Mao
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.2
Sprint: Sharding 2019-09-09
Participants:
Linked BF Score: 0

 Description   

The unit test is no longer valid after SERVER-42772, because now the coordinator is removed from the catalog asynchronously.

However, we could add some more test coverage:

  • That a coordinator is removed from the catalog on completion. From a quick search, I only foundĀ one unit test of this, and it is for when the coordinator is canceled. We could add coverage for the coordinator completing successfully or with an error.
  • That calling TransactionCoordinatorService::coordinateCommit for a lsid and txnNumber whose coordinator has completed either returns boost::none (because the coordinator has already been removed) or a ready future (the coordinator has yet to be removed).


 Comments   
Comment by Githook User [ 22/Apr/20 ]

Author:

{'name': 'Chou Mao', 'email': 'chou.mao@10gen.com', 'username': 'cheahuychou'}

Message: SERVER-43100 Remove CoordinateCommitReturnsNoneIfCoordinatorWasRemoved unit test

(cherry picked from commit 2906eb342a59295dbcf9aabc8692efe963dda6bd)
Branch: v4.2
https://github.com/mongodb/mongo/commit/8210db607c1e9c9f6e675d425c29f3b93c9f36f3

Comment by Githook User [ 16/Sep/19 ]

Author:

{'name': 'Chou Mao', 'username': 'cheahuychou', 'email': 'chou.mao@10gen.com'}

Message: SERVER-43100 Remove CoordinateCommitReturnsNoneIfCoordinatorWasRemoved unit test
Branch: master
https://github.com/mongodb/mongo/commit/2906eb342a59295dbcf9aabc8692efe963dda6bd

Generated at Thu Feb 08 05:02:16 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.