[SERVER-43184] Remove unused ReplicationCoordinator methods and members Created: 05/Sep/19 Updated: 29/Oct/23 Resolved: 22/Oct/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.1 |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | A. Jesse Jiryu Davis | Assignee: | Haley Connelly |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Repl 2019-10-21, Repl 2019-11-04 |
| Participants: |
| Description |
|
It appears that the setCanAcceptNonLocalWrites, _getCurrentCommittedLogicalTime_inlock, _canAcceptWritesFor_inlock, _canAcceptWritesFor_inlock, checkIfCommitQuorumIsSatisfied, getNumUncommittedSnapshots, and getWriteConcernMajorityShouldJournal_inlock virtual methods and their implementations are unused. Same for _snapshotNameGenerator in ReplicationCoordinatorImpl and ReplicationCoordinatorImplMock, and _uncommittedSnapshots in ReplicationCoordinatorImpl. |
| Comments |
| Comment by Githook User [ 22/Oct/19 ] |
|
Author: {'name': 'Haley Connelly', 'username': 'haleyConnelly', 'email': 'haley.connelly@10gen.com'}Message: |
| Comment by Haley Connelly [ 17/Oct/19 ] |
|
setCanAcceptNonLocalWrites is used inside _updateMemberStateFromTopologyCoordinator thus, we don't believe it should be removed for this ticket. Additionally getWriteConcernMajorityShouldJournal_inlock is used in both ReplicationCoordinatorImpl::getWriteConcernMajorityShouldJournal and ReplicationCoordinatorImpl::_populateUnsetWriteConcernOptionsSyncMode so we don't believe it should be removed in this ticket without further investigation. |