[SERVER-43206] All callers of DatabaseImpl::dropCollectionEvenIfSystem must first assert under a lock that no index builds are in progress Created: 06/Sep/19 Updated: 27/Oct/23 Resolved: 20/Mar/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Dianna Hohensee (Inactive) | Assignee: | Gregory Wlodarek |
| Resolution: | Gone away | Votes: | 0 |
| Labels: | groomed | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||
| Sprint: | Execution Team 2020-04-06 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Linked BF Score: | 9 | ||||||||||||||||||||
| Description |
|
TLDR: DatabaseImpl::dropCollectionEvenIfSystem invariants against index builds in progress by looking at the IndexCatalog state. However, the IndexBuildsCoordinator needs to clean up state after an index build, expecting the collection to continue to exist, without a lock. ---------------------------------- That's ^ one proposal for how to fix the problem. I haven't thought about other options. It isn't great because there's no way to enforce new callers of DatabaseImpl::dropCollectionEvenIfSystem don't mess up. ------------------------------- |
| Comments |
| Comment by Gregory Wlodarek [ 20/Mar/20 ] |
|
I took a look at this and the associated BF. With the abort changes made to drop (
Today, in no way should we be dropping collections with index builds still registered to the IndexBuildsCoordinator. |
| Comment by Dianna Hohensee (Inactive) [ 27/Feb/20 ] |
|
We would have to look at how index build tear down works now (if it has a final form). The BF was closed because it didn't reoccur for a long time, not because there was a known fix that went into master. |
| Comment by Connie Chen [ 20/Feb/20 ] |
|
Review whether this is necessary as the linked BF seems to have gone away |