[SERVER-43307] Avoid checking _checkIfWriteConcernCanBeSatisfied_inlock in ReplicationCoordinatorImpl::_doneWaitingForReplication_inlock Created: 12/Sep/19  Updated: 29/Oct/23  Resolved: 03/Oct/19

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Task Priority: Major - P3
Reporter: Lingzhi Deng Assignee: Lingzhi Deng
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-43135 Introduce a future-based API for wait... Closed
Backwards Compatibility: Fully Compatible
Sprint: Repl 2019-10-07
Participants:

 Description   

The answer to _checkIfWriteConcernCanBeSatisfied_inlock is rarely changed unless a replSetReconfig happens. Thus, it is more efficient to avoid checking that in ReplicationCoordinatorImpl::_doneWaitingForReplication_inlock. Instead, we should change ReplicationCoordinatorImpl::_setCurrentRSConfig to wake up waiters with ERROR if their writeConcern can no longer be satisfied.



 Comments   
Comment by Githook User [ 03/Oct/19 ]

Author:

{'name': 'Lingzhi Deng', 'username': 'ldennis', 'email': 'lingzhi.deng@mongodb.com'}

Message: SERVER-43307: Avoid checking _checkIfWriteConcernCanBeSatisfied_inlock in _doneWaitingForReplication_inlock
Branch: master
https://github.com/mongodb/mongo/commit/e19a6b321d73f5e7df177895e6ee5a596f60602a

Generated at Thu Feb 08 05:02:50 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.