[SERVER-43372] Move CryptDReplicationCoordinatorNoOp from enterprise to community repo Created: 18/Sep/19  Updated: 29/Oct/23  Resolved: 23/Sep/19

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.2.1, 4.3.1

Type: Improvement Priority: Major - P3
Reporter: A. Jesse Jiryu Davis Assignee: A. Jesse Jiryu Davis
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.2
Sprint: Repl 2019-09-23
Participants:

 Description   

For SERVER-42520, bernard.gorman created a CryptDReplicationCoordinatorNoOp class with empty implementations of all the ReplicationCoordinator interface methods. This code is part of mongocryptd in the enterprise repo.

For SERVER-41882 and related code cleanups we're actively changing the ReplicationCoordinator interface, and I expect we'll continue to change it. Changes are inconvenient, however, because every change must be coordinated across the community and enterprise repos.

Let's move CryptDReplicationCoordinatorNoOp into the community code base and rename it ReplicationCoordinatorNoOp, so we can change it in sync with ReplicationCoordinator. Code in the enterprise module can still use the NoOp class (only for instantiating it), but changes in that class won't affect the enterprise code, since it doesn't explicitly call any of its methods.



 Comments   
Comment by Githook User [ 24/Sep/19 ]

Author:

{'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}

Message: SERVER-43372 Add ReplicationCoordinatorNoOp
Branch: v4.2
https://github.com/mongodb/mongo/commit/b3a9f103f983ab1bdeff477d4c498cc030691839

Comment by Githook User [ 24/Sep/19 ]

Author:

{'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}

Message: SERVER-43372 Move ReplicationCoordinatorNoOp to community
Branch: v4.2
https://github.com/10gen/mongo-enterprise-modules/commit/209698d8c1659ce23e5690bc18a16926e6eda1cc

Comment by A. Jesse Jiryu Davis [ 23/Sep/19 ]

Requesting backport to 4.2, since PM-1400 "Reduce Client Time To Recovery On Topology Changes" will require ReplicationCoordinator interface changes and we intend to backport some of that work. If desired we can leave the backport unscheduled until we're sure about backporting the dependent work in PM-1400.

Comment by Githook User [ 23/Sep/19 ]

Author:

{'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}

Message: SERVER-43372 Add ReplicationCoordinatorNoOp
Branch: master
https://github.com/mongodb/mongo/commit/e2c85ad312f7071cb748ae0633c64245da8bd53c

Generated at Thu Feb 08 05:03:01 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.