[SERVER-43447] Complete TODO listed in SERVER-31968 Created: 23/Sep/19  Updated: 29/Oct/23  Resolved: 10/Oct/19

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Task Priority: Major - P3
Reporter: PM Bot Assignee: Dianna Hohensee (Inactive)
Resolution: Fixed Votes: 0
Labels: autogen-todo
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-31968 Refactor FCV component code in order ... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2019-10-21
Participants:

 Comments   
Comment by Githook User [ 10/Oct/19 ]

Author:

{'username': 'DiannaHohensee', 'email': 'dianna.hohensee@mongodb.com', 'name': 'Dianna Hohensee'}

Message: SERVER-43447 Removing FCV related TODO in pipeline/expression.cpp (not doing it)
Branch: master
https://github.com/mongodb/mongo/commit/00956ca3af08029dae3e4e0eb2c27bcf8a6bd923

Comment by Dianna Hohensee (Inactive) [ 08/Oct/19 ]

Sounds good to me. We just need to do away with the TODO, then.

Comment by Charlie Swanson [ 07/Oct/19 ]

dianna.hohensee this code is currently dead but will revive itself whenever we add the first expression for 4.4 which I expect we will do at some point. I'd prefer to keep the code around and leave the comment without a TODO.

I could also see an argument for deleting the code and re-adding it when we need it, but I think it's good to think about and maintain in the meantime so we can tell which changes make this code harder or easier to support. It's a mechanism I think we'll need for every foreseeable release with a new expression, which recently has been 100% of releases.

Comment by Dianna Hohensee (Inactive) [ 04/Oct/19 ]

This TODO was added in SERVER-33174 by the query team for v4.0 upgrade/downgrade. This is the code. It was decided NOT to do SERVER-31968, so the TODO in the query code must be removed, whether or not the comment remains intact.

However, it looks like we might be able to delete the code. charlie.swanson, is this old FCV upgrade/downgrade code that can be safely deleted now?

Generated at Thu Feb 08 05:03:14 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.