[SERVER-43465] Remove InvalidBSON try/catch blocks for ReplSetGetStatus wall clock times Created: 23/Sep/19  Updated: 29/Oct/23  Resolved: 03/Dec/19

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.3.3

Type: Task Priority: Major - P3
Reporter: PM Bot Assignee: Maria van Keulen
Resolution: Fixed Votes: 0
Labels: autogen-todo
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-40078 Add wall clock time corresponding to ... Closed
is related to SERVER-40737 Use Date_t() as default wallTime valu... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2019-11-18, Execution Team 2019-12-02, Execution Team 2019-12-16
Participants:

 Description   

These try/catch blocks are no longer necessary as of SERVER-40737. All try/catch blocks labeled with SERVER-40078 should be removed, since ReplSetGetStatus should no longer output InvalidBSON for the wall clock times.



 Comments   
Comment by Githook User [ 03/Dec/19 ]

Author:

{'name': 'Maria van Keulen', 'username': 'mvankeulen94', 'email': 'maria.vankeulen@mongodb.com'}

Message: SERVER-43465 Remove unnecessary InvalidBSON replSetGetStatus handling
Branch: master
https://github.com/mongodb/mongo/commit/e4347d57e5e1d6e2090417d4560d713f2cd2743e

Comment by Maria van Keulen [ 23/Sep/19 ]

Acknowledged. It looks like those TODOs were added as part of SERVER-32295. They are all of the following format. As of SERVER-40737, I don't think the invalid BSON should be a problem anymore.

I will update the ticket description.

Comment by Judah Schvimer [ 23/Sep/19 ]

The TODO bot does not create tickets for TODOs that a ticket introduces. It creates tickets for TODOs a ticket was supposed to address, but did not address. SERVER-40078 did not address 3 TODOs, including this one. Grep for "40078" in the codebase to see. Assigning back since you closed the ticket.

Comment by Maria van Keulen [ 23/Sep/19 ]

The patch for SERVER-40078 did not add any TODO comments. If anything, the TODO bot may have picked up this todo, which predates this patch. I will send this to the replication team to investigate.

Generated at Thu Feb 08 05:03:17 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.