[SERVER-43474] Complete TODO listed in SERVER-33983 Created: 23/Sep/19  Updated: 29/Oct/23  Resolved: 06/Feb/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.3.4

Type: Task Priority: Major - P3
Reporter: PM Bot Assignee: Jack Mulrow
Resolution: Fixed Votes: 0
Labels: autogen-todo
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-33983 Add support for transactions in readC... Closed
Backwards Compatibility: Fully Compatible
Sprint: Sharding 2020-01-13, Sharding 2020-01-27, Sharding 2020-02-10
Participants:

 Comments   
Comment by Githook User [ 06/Feb/20 ]

Author:

{'name': 'Jack Mulrow', 'username': 'jsmulrow', 'email': 'jack.mulrow@mongodb.com'}

Message: SERVER-43474 Complete TODO listed in SERVER-33983
Branch: master
https://github.com/mongodb/mongo/commit/b0827ec75609c03f835d81417d7776e3015289a0

Comment by Jack Mulrow [ 05/Feb/20 ]

This TODO was for running the core/txns tests in the majority_read_concern_passthrough suite, but instead in SERVER-33983 I ended up adding new suites that run just those tests with majority read concern because it was easier to do this with the network_error_txn_override.js override file than with set_read_and_write_concern.js, which is used by read_concern_majority_passthrough.yml.

We actually ended up changing those suites to use "local" read concern in SERVER-38733, but I don't think that matters since the commit for SERVER-33983 still added the intended test coverage at the time. So I think it's fine to just delete these TODOs.

Comment by Mira Carey [ 03/Jan/20 ]

I can't tell if SERVER-33983 was supposed to address buildscripts/resmokeconfig/suites/read_concern_majority_passthrough.yml or if there's more to do

Generated at Thu Feb 08 05:03:18 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.