[SERVER-43623] Stop catching exceptions in NetworkInterfaceASIO Created: 25/Sep/19  Updated: 29/Oct/23  Resolved: 10/Dec/19

Status: Closed
Project: Core Server
Component/s: Networking
Affects Version/s: None
Fix Version/s: 4.2.3, 4.3.3

Type: Improvement Priority: Major - P3
Reporter: Matthew Saltz (Inactive) Assignee: Rahul Sundararaman (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.2, v4.0, v3.6
Sprint: Service Arch 2019-12-02, Service Arch 2019-12-16
Participants:
Case:

 Description   

We catch exceptions that throw here, which means that we don't have a backtrace for these exceptions, which leads to hard-to-diagnose issues like SERVER-43021. We should stop catching these exceptions and let the process crash on its own due to the noexcept nature of lambdas passed to std::thread



 Comments   
Comment by Githook User [ 10/Dec/19 ]

Author:

{'name': 'Rahul Sundararaman', 'email': 'rahul.sundararaman@mongodb.com'}

Message: SERVER-43623 Stop catching exceptions in NetworkInterfaceASIO

(cherry picked from commit 661e817b9cdf7b32ab1b535e6a0a04595d796b39)
Branch: v4.2
https://github.com/mongodb/mongo/commit/b34a50fd84acb963b20b4f5d045715507ff24a58

Comment by Githook User [ 10/Dec/19 ]

Author:

{'email': 'rahul.sundararaman@mongodb.com', 'name': 'Rahul Sundararaman'}

Message: SERVER-43623 Stop catching exceptions in NetworkInterfaceASIO
Branch: master
https://github.com/mongodb/mongo/commit/661e817b9cdf7b32ab1b535e6a0a04595d796b39

Generated at Thu Feb 08 05:03:38 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.