[SERVER-43627] Remove v4.2 FCV handling from ValidationCollections JS test hook Created: 25/Sep/19 Updated: 27/Oct/23 Resolved: 15/Jun/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage, Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Dianna Hohensee (Inactive) | Assignee: | Backlog - Server Tooling and Methods (STM) (Inactive) |
| Resolution: | Works as Designed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Assigned Teams: |
Server Tooling & Methods
|
||||||||||||
| Participants: | |||||||||||||
| Description |
|
We do not need FCV handling in the validate test hook in v4.4; and we should not be only running the validate cmd against FCV 4.2 in v4.4. |
| Comments |
| Comment by Brooke Miller [ 15/Jun/20 ] |
|
Per Max's comment above, there is no code to handle FCV 4.2 in the validate_collections.js hook. |
| Comment by Dianna Hohensee (Inactive) [ 25/Sep/19 ] |
|
My motivation is to get rid of unused/unneeded code. It makes the code more complicated to understand. We typically remove release specific FCV handling code after a release. Could we add FCV handling to the validate cmd itself instead of this testing logic, if we encounter such a need again? I wondered why we didn't do that for the index format change. |
| Comment by Max Hirschhorn [ 25/Sep/19 ] |
|
What's the motivation for removing the TestData.forceValidationWithFeatureCompatibilityVersion logic from the validate_collections.js hook? The logic itself isn't specific to FCV=4.2 and I suspect we'll likely find ourselves re-adding it in a future release, much like we did with If we aren't required to run collection validation with the latest feature compatibility version in MongoDB 4.4, then it seems like we could simply remove the setting from the various jstestfuzz*.yml test suites and still leave the support for it in. |