[SERVER-43627] Remove v4.2 FCV handling from ValidationCollections JS test hook Created: 25/Sep/19  Updated: 27/Oct/23  Resolved: 15/Jun/20

Status: Closed
Project: Core Server
Component/s: Storage, Testing Infrastructure
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Dianna Hohensee (Inactive) Assignee: Backlog - Server Tooling and Methods (STM) (Inactive)
Resolution: Works as Designed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-37074 Validation hook should continue downg... Closed
related to SERVER-36718 Validation hook should upgrade before... Closed
Assigned Teams:
Server Tooling & Methods
Participants:

 Description   

SERVER-36718 and SERVER-37074 (re-)introduced code to ensure that the validate cmd in the ValidateCollections test hook would only run against FCV 4.2 in v4.2 and that we finished downgrading to FCV 4.0 if necessary before upgrading to FCV 4.2. This was due to an index format change that occurred in FCV 4.2 and then continued to exist after downgrade to FCV 4.0, which validate did not allow in FCV 4.0.

We do not need FCV handling in the validate test hook in v4.4; and we should not be only running the validate cmd against FCV 4.2 in v4.4.



 Comments   
Comment by Brooke Miller [ 15/Jun/20 ]

Per Max's comment above, there is no code to handle FCV 4.2 in the  validate_collections.js hook.

Comment by Dianna Hohensee (Inactive) [ 25/Sep/19 ]

My motivation is to get rid of unused/unneeded code. It makes the code more complicated to understand. We typically remove release specific FCV handling code after a release.

Could we add FCV handling to the validate cmd itself instead of this testing logic, if we encounter such a need again? I wondered why we didn't do that for the index format change.

Comment by Max Hirschhorn [ 25/Sep/19 ]

What's the motivation for removing the TestData.forceValidationWithFeatureCompatibilityVersion logic from the validate_collections.js hook? The logic itself isn't specific to FCV=4.2 and I suspect we'll likely find ourselves re-adding it in a future release, much like we did with SERVER-36718 after the changes from 67500ef as part of SERVER-29350.

If we aren't required to run collection validation with the latest feature compatibility version in MongoDB 4.4, then it seems like we could simply remove the setting from the various jstestfuzz*.yml test suites and still leave the support for it in.

Generated at Thu Feb 08 05:03:39 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.