[SERVER-43639] Two phase index build completion should use timestamp from commitIndexBuild oplog entry Created: 25/Sep/19  Updated: 29/Oct/23  Resolved: 10/Oct/19

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Task Priority: Major - P3
Reporter: Louis Williams Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-43692 enable two phase index builds by default Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2019-10-07, Execution Team 2019-10-21
Participants:

 Description   

When two phase index builds are enabled, timestamp_index_builds.js currently fails in the third phase of the test where the node is restarted as a standalone node. The underlying issue seems to be that the completion of a two phase index build, represented in the oplog by the commitIndexBuild oplog entry, is not timestamped correctly. Currently, we obtain a ghost timestamp for the purposes of writing to the mdb catalog on a successful index build. Now that we have the commitIndexBuild oplog entry, we should be able use a timestamp that is present in the oplog.



 Comments   
Comment by Githook User [ 10/Oct/19 ]

Author:

{'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}

Message: SERVER-43639 complete index builds on the secondary using the timestamp from the commitIndexBuild oplog entry
Branch: master
https://github.com/mongodb/mongo/commit/6fa4758e50857bb7dcb792d9740216663afce1bb

Comment by Githook User [ 10/Oct/19 ]

Author:

{'name': 'Benety Goh', 'username': 'benety', 'email': 'benety@mongodb.com'}

Message: SERVER-43639 fix tests to support two phase index builds
Branch: master
https://github.com/mongodb/mongo/commit/69ef3ed5cf4ac634fd7a749f9428871ec6f40fd2

Comment by Githook User [ 10/Oct/19 ]

Author:

{'name': 'Benety Goh', 'username': 'benety', 'email': 'benety@mongodb.com'}

Message: SERVER-43639 IndexBuildsCoordinator::commitIndexBuild() returns void
Branch: master
https://github.com/mongodb/mongo/commit/66385e1723066f2c435c329a220c67220403d7ac

Generated at Thu Feb 08 05:03:41 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.