[SERVER-43642] Remove IndexBuilder in favor of IndexBuildsCoordinator Created: 25/Sep/19 Updated: 29/Oct/23 Resolved: 22/Nov/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.1 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Louis Williams | Assignee: | Benety Goh |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Sprint: | Execution Team 2019-12-02 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
We still use the IndexBuilder to build indexes in the foreground thread in applyOps. This is currently only used when creating indexes with applyOps on a primary or when rebuilding indexes during replication recovery. We have too many duplicated implementations of index building and removing this class entirely would help to prevent diverging logic. The functionality can be entirely replaced by using the IndexBuildsCoordinator and waiting for the future, similar to what we do in create_indexes.cpp. |
| Comments |
| Comment by Githook User [ 22/Nov/19 ] |
|
Author: {'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}Message: |
| Comment by Githook User [ 21/Nov/19 ] |
|
Author: {'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}Message: Last reference was removed in commit 2f5feed026e1c22bce29cf2efe746d55879d4a14. |
| Comment by Githook User [ 21/Nov/19 ] |
|
Author: {'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}Message: |
| Comment by Githook User [ 20/Nov/19 ] |
|
Author: {'name': 'Benety Goh', 'username': 'benety', 'email': 'benety@mongodb.com'}Message: |
| Comment by Githook User [ 20/Nov/19 ] |
|
Author: {'name': 'Benety Goh', 'username': 'benety', 'email': 'benety@mongodb.com'}Message: make IndexBuildsCoordinator::updateCurOpOpDescription() public |
| Comment by Githook User [ 20/Nov/19 ] |
|
Author: {'name': 'Benety Goh', 'username': 'benety', 'email': 'benety@mongodb.com'}Message: |
| Comment by Benety Goh [ 10/Oct/19 ] |
|
|