[SERVER-43738] clang-tidy error in shard_key_pattern_test.cpp Created: 30/Sep/19  Updated: 29/Oct/23  Resolved: 03/Oct/19

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Bug Priority: Major - P3
Reporter: Suganthi Mani Assignee: Daniel Gottlieb (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Execution Team 2019-10-07
Participants:
Linked BF Score: 50

 Description   

[2019/09/27 14:52:31.512] /data/mci/f7b2a6acdc3d01ded6cc8f0f20c1760d/src/src/mongo/s/shard_key_pattern_test.cpp:45:5: error: object destroyed immediately after creation; did you mean to name the object? [bugprone-unused-raii,-warnings-as-errors]
 [2019/09/27 14:52:31.512]     ShardKeyPattern(BSON("a" << 1));
 [2019/09/27 14:52:31.512]     ^              ~
 [2019/09/27 14:52:31.512]                     give_me_a_name
 [2019/09/27 14:52:31.512] /data/mci/f7b2a6acdc3d01ded6cc8f0f20c1760d/src/src/mongo/s/shard_key_pattern_test.cpp:46:5: error: object destroyed immediately after creation; did you mean to name the object? [bugprone-unused-raii,-warnings-as-errors]
 [2019/09/27 14:52:31.512]     ShardKeyPattern(BSON("a" << 1.0f));
 [2019/09/27 14:52:31.512]     ^              ~
 [2019/09/27 14:52:31.512]                     give_me_a_name
 [2019/09/27 14:52:31.513] /data/mci/f7b2a6acdc3d01ded6cc8f0f20c1760d/src/src/mongo/s/shard_key_pattern_test.cpp:47:5: error: object destroyed immediately after creation; did you mean to name the object? [bugprone-unused-raii,-warnings-as-errors]
 [2019/09/27 14:52:31.513]     ShardKeyPattern(BSON("a" << (long long)1L));
 [2019/09/27 14:52:31.513]     ^              ~
 [2019/09/27 14:52:31.513]                     give_me_a_name
 [2019/09/27 14:52:31.513] /data/mci/f7b2a6acdc3d01ded6cc8f0f20c1760d/src/src/mongo/s/shard_key_pattern_test.cpp:48:5: error: object destroyed immediately after creation; did you mean to name the object? [bugprone-unused-raii,-warnings-as-errors]
 [2019/09/27 14:52:31.513]     ShardKeyPattern(BSON("a"
 [2019/09/27 14:52:31.513]     ^              ~
 [2019/09/27 14:52:31.513]                     give_me_a_name
 [2019/09/27 14:52:31.513] /data/mci/f7b2a6acdc3d01ded6cc8f0f20c1760d/src/src/mongo/s/shard_key_pattern_test.cpp:65:5: error: object destroyed immediately after creation; did you mean to name the object? [bugprone-unused-raii,-warnings-as-errors]
 [2019/09/27 14:52:31.513]     ShardKeyPattern(BSON("a" << 1 << "b" << 1));
 [2019/09/27 14:52:31.513]     ^              ~
 [2019/09/27 14:52:31.513]                     give_me_a_name
 [2019/09/27 14:52:31.513] /data/mci/f7b2a6acdc3d01ded6cc8f0f20c1760d/src/src/mongo/s/shard_key_pattern_test.cpp:66:5: error: object destroyed immediately after creation; did you mean to name the object? [bugprone-unused-raii,-warnings-as-errors]
 [2019/09/27 14:52:31.513]     ShardKeyPattern(BSON("a" << 1.0f << "b" << 1.0));
 [2019/09/27 14:52:31.513]     ^              ~
 [2019/09/27 14:52:31.513]                     give_me_a_name
 [2019/09/27 14:52:31.513] /data/mci/f7b2a6acdc3d01ded6cc8f0f20c1760d/src/src/mongo/s/shard_key_pattern_test.cpp:67:5: error: object destroyed immediately after creation; did you mean to name the object? [bugprone-unused-raii,-warnings-as-errors]
 [2019/09/27 14:52:31.513]     ShardKeyPattern(BSON("a" << 1 << "b" << 1.0 << "c" << 1.0f));
 [2019/09/27 14:52:31.513]     ^              ~
 [2019/09/27 14:52:31.513]                     give_me_a_name
 [2019/09/27 14:52:31.513] /data/mci/f7b2a6acdc3d01ded6cc8f0f20c1760d/src/src/mongo/s/shard_key_pattern_test.cpp:78:5: error: object destroyed immediately after creation; did you mean to name the object? [bugprone-unused-raii,-warnings-as-errors]
 [2019/09/27 14:52:31.513]     ShardKeyPattern(BSON("a.b" << 1));
 [2019/09/27 14:52:31.513]     ^              ~
 [2019/09/27 14:52:31.513]                     give_me_a_name
 [2019/09/27 14:52:31.513] /data/mci/f7b2a6acdc3d01ded6cc8f0f20c1760d/src/src/mongo/s/shard_key_pattern_test.cpp:79:5: error: object destroyed immediately after creation; did you mean to name the object? [bugprone-unused-raii,-warnings-as-errors]
 [2019/09/27 14:52:31.513]     ShardKeyPattern(BSON("a.b.c.d" << 1.0));
 [2019/09/27 14:52:31.513]     ^              ~
 [2019/09/27 14:52:31.513]                     give_me_a_name
 [2019/09/27 14:52:31.513] /data/mci/f7b2a6acdc3d01ded6cc8f0f20c1760d/src/src/mongo/s/shard_key_pattern_test.cpp:80:5: error: object destroyed immediately after creation; did you mean to name the object? [bugprone-unused-raii,-warnings-as-errors]
 [2019/09/27 14:52:31.513]     ShardKeyPattern(BSON("a" << 1 << "c.d" << 1.0 << "e.f.g" << 1.0f));
 [2019/09/27 14:52:31.513]     ^              ~
 [2019/09/27 14:52:31.513]                     give_me_a_name
 [2019/09/27 14:52:31.513] /data/mci/f7b2a6acdc3d01ded6cc8f0f20c1760d/src/src/mongo/s/shard_key_pattern_test.cpp:81:5: error: object destroyed immediately after creation; did you mean to name the object? [bugprone-unused-raii,-warnings-as-errors]
 [2019/09/27 14:52:31.513]     ShardKeyPattern(BSON("a" << 1 << "a.b" << 1.0 << "a.b.c" << 1.0f));
 [2019/09/27 14:52:31.513]     ^              ~
 [2019/09/27 14:52:31.513]                     give_me_a_name



 Comments   
Comment by Githook User [ 03/Oct/19 ]

Author:

{'name': 'Daniel Gottlieb', 'username': 'dgottlieb', 'email': 'daniel.gottlieb@mongodb.com'}

Message: SERVER-43738: Remove bugprone-unused-raii in shard_key_pattern_test.cpp.
Branch: master
https://github.com/mongodb/mongo/commit/5f8b8e01e867fa22c48636e754886dee8a84cf38

Generated at Thu Feb 08 05:03:58 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.