[SERVER-43760] Reintroduce the ODR detector in a meaningful way Created: 02/Oct/19  Updated: 29/Oct/23  Resolved: 19/Aug/20

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Bug Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Andrew Morrow (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Dev Platform 2020-08-24
Participants:

 Description   

We attempted to enable the link-time ODR detector in the past. The flag to do so --detect-odr-violations is spammed all over the place in the CI configuration (though we only ever really intended to turn it on for one builder). Unfortunately, due to a logic error, the logic to enable the actual link time flag is broken, and the required linker flag is never enabled. When that error is fixed, and we apply the flag, we do find ODR violations.

We should migrate the ODR detection to a single builder, remove the spamming of the flag through the CI system, fix the logic error, and then address any found ODR violations.



 Comments   
Comment by Githook User [ 19/Aug/20 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-43760 Re-enable the ODR detector on a single appropriate --opt=off builder
Branch: master
https://github.com/mongodb/mongo/commit/3e0366d2b1ff45a3ea91b63793743023479d9c4a

Generated at Thu Feb 08 05:04:02 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.