[SERVER-43762] tighten the overload set for BSONObjBuilder::appendNumber Created: 02/Oct/19  Updated: 29/Oct/23  Resolved: 05/Mar/21

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 4.9.0

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: Bynn Lee
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Duplicate
is duplicated by SERVER-34931 Forbid appending unsigned integral ty... Closed
Problem/Incident
Related
is related to SERVER-75293 Different return types for the connec... Closed
is related to SERVER-42182 Reimplement SortStage in terms of Sor... Closed
Backwards Compatibility: Fully Compatible
Sprint: Dev Tools 2019-11-04, Dev Tools 2019-12-02, Dev Tools 2019-12-16, Dev Tools 2019-12-30, Execution Team 2021-02-08, Execution Team 2021-02-22, Execution Team 2021-03-08, Execution Team 2021-03-22
Participants:
Linked BF Score: 95

 Description   

In SERVER-9763 we improved the overload set for BSONObjBuilder::append.

We still have the same trouble with BSONObjBuilder::appendNumber.
Certain flags and compiler versions will complain about ambiguity, MacOS clang debug, argument is uint64_t, overload set is (int,double,size_t,long long). We probably need to get size_t out of the overload set.

uint64_t should be size_t but isn't?

This causes wasteful BFs:
BF-14896
BF-11187
BF-5725

and cleanup work:
https://github.com/mongodb/mongo/commit/be20a34cf0af56cccc378861abb43e528daacea5



 Comments   
Comment by Githook User [ 05/Mar/21 ]

Author:

{'name': 'Bynn Lee', 'email': 'bynn.lee@mongodb.com', 'username': 'bynn'}

Message: SERVER-43762 tighten the overload set for BSONObjBuilder::appendNumber
Branch: master
https://github.com/mongodb/mongo/commit/51ba5d1540ea957a7fb03a08bbb1ef4f9d6e80d2

Comment by Githook User [ 25/Feb/21 ]

Author:

{'name': 'Bynn Lee', 'email': 'bynn.lee@mongodb.com', 'username': 'bynn'}

Message: Revert "SERVER-43762 tighten the overload set for BSONObjBuilder::appendNumber"

This reverts commit 3307ba57eef2dfff9abe2413e39058ac9451ec04.
Branch: master
https://github.com/mongodb/mongo/commit/b8107b8e481ae7073d30304196a3028145c80634

Comment by Githook User [ 25/Feb/21 ]

Author:

{'name': 'Bynn Lee', 'email': 'bynn.lee@mongodb.com', 'username': 'bynn'}

Message: Revert "SERVER-43762 tighten the overload set for BSONObjBuilder::appendNumber"

This reverts commit 98f42065a3f530024980e72ef0a15a371c28e32b.
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/07a2f1b3245d2a18a8b53482091aa32cbf9210be

Comment by Githook User [ 22/Feb/21 ]

Author:

{'name': 'Bynn Lee', 'email': 'bynn.lee@mongodb.com', 'username': 'bynn'}

Message: SERVER-43762 tighten the overload set for BSONObjBuilder::appendNumber
Branch: master
https://github.com/mongodb/mongo/commit/3307ba57eef2dfff9abe2413e39058ac9451ec04

Comment by Githook User [ 22/Feb/21 ]

Author:

{'name': 'Bynn Lee', 'email': 'bynn.lee@mongodb.com', 'username': 'bynn'}

Message: SERVER-43762 tighten the overload set for BSONObjBuilder::appendNumber
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/98f42065a3f530024980e72ef0a15a371c28e32b

Comment by Ian Whalen (Inactive) [ 05/Feb/21 ]

Author:

{'username': u'evrg-bot-webhook', 'name': u'Bynn Lee', 'email': u'bynn.lee@mongodb.com'}

Message:SERVER-43762 Move top_drop.js from noPassthroughWithMongod to Core
Branch:master
https://github.com/mongodb/mongo/commit/81d03da0472dff56f8430c9d003f9d2a43892ba2

Comment by Githook User [ 05/Feb/21 ]

Author:

{'name': 'Bynn Lee', 'email': 'bynn.lee@mongodb.com', 'username': 'bynn'}

Message: Revert "SERVER-43762 Move top_drop.js from noPassthroughWithMongod to Core"

This reverts commit 81d03da0472dff56f8430c9d003f9d2a43892ba2.
Branch: master
https://github.com/mongodb/mongo/commit/7d2be384b91c16662add018d717d3cf26d2e2098

Comment by Bynn Lee [ 04/Feb/21 ]

https://mongodbcr.appspot.com/752820016/

https://mongodbcr.appspot.com/747220015/

Comment by Connie Chen [ 21/Sep/20 ]

billy.donahue We'll take out the overload for size_t.

Comment by Billy Donahue [ 13/Aug/20 ]

I don't understand what the closing comment means by "different builds on different platforms".

The proposed behavior for append is already what is being done for appendNumber.

Generated at Thu Feb 08 05:04:02 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.