[SERVER-43762] tighten the overload set for BSONObjBuilder::appendNumber Created: 02/Oct/19 Updated: 29/Oct/23 Resolved: 05/Mar/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 4.9.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Billy Donahue | Assignee: | Bynn Lee |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||
| Sprint: | Dev Tools 2019-11-04, Dev Tools 2019-12-02, Dev Tools 2019-12-16, Dev Tools 2019-12-30, Execution Team 2021-02-08, Execution Team 2021-02-22, Execution Team 2021-03-08, Execution Team 2021-03-22 | ||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||
| Linked BF Score: | 95 | ||||||||||||||||||||||||||||
| Description |
|
In We still have the same trouble with BSONObjBuilder::appendNumber. uint64_t should be size_t but isn't? This causes wasteful BFs: and cleanup work: |
| Comments |
| Comment by Githook User [ 05/Mar/21 ] |
|
Author: {'name': 'Bynn Lee', 'email': 'bynn.lee@mongodb.com', 'username': 'bynn'}Message: |
| Comment by Githook User [ 25/Feb/21 ] |
|
Author: {'name': 'Bynn Lee', 'email': 'bynn.lee@mongodb.com', 'username': 'bynn'}Message: Revert " This reverts commit 3307ba57eef2dfff9abe2413e39058ac9451ec04. |
| Comment by Githook User [ 25/Feb/21 ] |
|
Author: {'name': 'Bynn Lee', 'email': 'bynn.lee@mongodb.com', 'username': 'bynn'}Message: Revert " This reverts commit 98f42065a3f530024980e72ef0a15a371c28e32b. |
| Comment by Githook User [ 22/Feb/21 ] |
|
Author: {'name': 'Bynn Lee', 'email': 'bynn.lee@mongodb.com', 'username': 'bynn'}Message: |
| Comment by Githook User [ 22/Feb/21 ] |
|
Author: {'name': 'Bynn Lee', 'email': 'bynn.lee@mongodb.com', 'username': 'bynn'}Message: |
| Comment by Ian Whalen (Inactive) [ 05/Feb/21 ] |
|
Author: {'username': u'evrg-bot-webhook', 'name': u'Bynn Lee', 'email': u'bynn.lee@mongodb.com'}Message: |
| Comment by Githook User [ 05/Feb/21 ] |
|
Author: {'name': 'Bynn Lee', 'email': 'bynn.lee@mongodb.com', 'username': 'bynn'}Message: Revert " This reverts commit 81d03da0472dff56f8430c9d003f9d2a43892ba2. |
| Comment by Bynn Lee [ 04/Feb/21 ] |
| Comment by Connie Chen [ 21/Sep/20 ] |
|
billy.donahue We'll take out the overload for size_t. |
| Comment by Billy Donahue [ 13/Aug/20 ] |
|
I don't understand what the closing comment means by "different builds on different platforms". The proposed behavior for append is already what is being done for appendNumber. |