[SERVER-43800] ClockSource::waitForConditionUntil shouldn't use unique_lock out of line Created: 03/Oct/19  Updated: 29/Oct/23  Resolved: 09/Oct/19

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Bug Priority: Major - P3
Reporter: Benjamin Caimano (Inactive) Assignee: Benjamin Caimano (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Related
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Service Arch 2019-10-21
Participants:
Linked BF Score: 21

 Description   

We have a somewhat dubious pattern here where it is possible for an alarm to invoke inline and attempt to hold a lock that was already acquired. The lock use itself isn't necessary, because condition variables are surprisingly atomic.



 Comments   
Comment by Githook User [ 31/Oct/19 ]

Author:

{'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com', 'name': 'Ben Caimano'}

Message: SERVER-41357 SERVER-41360 SERVER-43324 Add Mutex, BasicLockableAdaptor, and DiagnosticInfo

This commit backports Mutex, BasicLockableAdaptor, and DiagnosticInfo to
v4.2. These pieces came in completely in various interleaved commits.
The constituent commits partially included in this backport are listed
below. The majority of these commits are part of the "Improved
Diagnostics for Latches" epic.

Mutex:

BasicLockableAdaptor:

DiagnosticInfo:

Note that while this commit adds these pieces and integrates them into
the mongo-server codebase, it does not convert existing stdx::mutex
construction. It also does not include the updates to Interruptible that
were done as part of "Improved Diagnostics for Latches".
Branch: v4.2
https://github.com/mongodb/mongo/commit/3a05e4ce75cd03b09b52ec5943e1801c6d91279b

Comment by Githook User [ 10/Oct/19 ]

Author:

{'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}

Message: SERVER-43800 disable flaky test
Branch: master
https://github.com/mongodb/mongo/commit/dc65716e7ed6053e4ec1f7d1dfa82b435d46ba03

Comment by Githook User [ 09/Oct/19 ]

Author:

{'name': 'Ben Caimano', 'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com'}

Message: SERVER-43800 ClockSource::waitForConditionUntil shouldn't use unique_lock out of line
Branch: master
https://github.com/mongodb/mongo/commit/97ffc69bea04758e1c7f94e1075ef2bcce652999

Generated at Thu Feb 08 05:04:09 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.