[SERVER-43800] ClockSource::waitForConditionUntil shouldn't use unique_lock out of line Created: 03/Oct/19 Updated: 29/Oct/23 Resolved: 09/Oct/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Benjamin Caimano (Inactive) | Assignee: | Benjamin Caimano (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Sprint: | Service Arch 2019-10-21 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 21 | ||||||||
| Description |
|
We have a somewhat dubious pattern here where it is possible for an alarm to invoke inline and attempt to hold a lock that was already acquired. The lock use itself isn't necessary, because condition variables are surprisingly atomic. |
| Comments |
| Comment by Githook User [ 31/Oct/19 ] |
|
Author: {'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com', 'name': 'Ben Caimano'}Message: This commit backports Mutex, BasicLockableAdaptor, and DiagnosticInfo to Mutex: BasicLockableAdaptor: DiagnosticInfo:
Note that while this commit adds these pieces and integrates them into |
| Comment by Githook User [ 10/Oct/19 ] |
|
Author: {'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}Message: |
| Comment by Githook User [ 09/Oct/19 ] |
|
Author: {'name': 'Ben Caimano', 'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com'}Message: |