[SERVER-43879] OplogInterfaceLocal::next should return an owned BSON obj Created: 08/Oct/19 Updated: 29/Oct/23 Resolved: 08/Oct/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | 3.4.0, 3.6.0, 4.0.0, 4.2.0 |
| Fix Version/s: | 4.3.1, 3.4.24, 4.0.14 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Louis Williams | Assignee: | Louis Williams |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Operating System: | ALL | ||||
| Backport Requested: |
v4.2, v4.0, v3.6, v3.4
|
||||
| Sprint: | Execution Team 2019-10-21 | ||||
| Participants: | |||||
| Description |
|
OplogInterfaceLocal::next() returns an unowned BSONObj. This is problematic because callers in RollBackLocalOperations::onRemoteOperation() save the resulting object and call next() several times without taking ownership first. This results in a bugs where an unowned BSONObj can point to freed or overwritten memory. |
| Comments |
| Comment by Githook User [ 31/Oct/19 ] |
|
Author: {'name': 'Judah Schvimer', 'username': 'judahschvimer', 'email': 'judah.schvimer@10gen.com'}Message: (cherry picked from commit 11cc6bd375b1a6089047a44909efb9cb4d1ad97e) |
| Comment by Githook User [ 30/Oct/19 ] |
|
Author: {'name': 'Judah Schvimer', 'username': 'judahschvimer', 'email': 'judah.schvimer@10gen.com'}Message: (cherry picked from commit 11cc6bd375b1a6089047a44909efb9cb4d1ad97e) |
| Comment by Githook User [ 30/Oct/19 ] |
|
Author: {'name': 'Judah Schvimer', 'username': 'judahschvimer', 'email': 'judah.schvimer@10gen.com'}Message: (cherry picked from commit 11cc6bd375b1a6089047a44909efb9cb4d1ad97e) |
| Comment by Githook User [ 30/Oct/19 ] |
|
Author: {'username': 'judahschvimer', 'email': 'judah.schvimer@10gen.com', 'name': 'Judah Schvimer'}Message: (cherry picked from commit 11cc6bd375b1a6089047a44909efb9cb4d1ad97e) |
| Comment by Githook User [ 08/Oct/19 ] |
|
Author: {'name': 'Louis Williams', 'username': 'louiswilliams', 'email': 'louis.williams@mongodb.com'}Message: |