[SERVER-43885] Rename OplogApplierImpl methods Created: 08/Oct/19  Updated: 29/Oct/23  Resolved: 14/Oct/19

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Improvement Priority: Major - P3
Reporter: Mihai Andrei Assignee: Mihai Andrei
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Repl 2019-10-21
Participants:

 Description   

Currently, oplog application logic is split over several methods: _multiApply takes a batch of oplog entries and schedules threads to apply them in parallel, applyOplogGroup is the thread worker function which attempts to group inserts and calls applyOplogEntryBatch, which applies a single oplog entry or a group of inserts. While the code path is clear, the names are not. This is due to the ambiguity of terms such as 'batch' and 'group'. Given that batch refers to a set of oplog entries to be apply and group refers to a set of groupedInserts, we can rename the aforementioned methods as follows:

  • _multiApply will be renamed _applyOplogBatch.
  • applyOplogGroup will be renamed applyOplogBatchPerWorker.
  • -applyOplogEntryBatch will be renamed applyOplogEntryOrGroupedInserts.

Additionally, the class OplogEntryBatch will be renamed OplogEntryOrGroupedInserts.



 Comments   
Comment by Githook User [ 14/Oct/19 ]

Author:

{'name': 'Mihai Andrei', 'email': 'mihai.andrei@mongodb.com'}

Message: SERVER-43885 Rename OplogApplierImpl methods
Branch: master
https://github.com/mongodb/mongo/commit/c119ef45e3f1c2cc7f36c7b81d0731e332461c2b

Generated at Thu Feb 08 05:04:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.