[SERVER-43910] include Client/OpCtx information in LockManager::dump() output Created: 09/Oct/19 Updated: 29/Oct/23 Resolved: 16/Oct/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.1, 4.2.3, 4.0.15 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Benety Goh | Assignee: | Benety Goh |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||||||||||||||||||
| Backport Requested: |
v4.2, v4.0
|
||||||||||||||||||||||||||||||||||||||||||||
| Sprint: | Execution Team 2019-10-21 | ||||||||||||||||||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||||||||||||||||||
| Linked BF Score: | 0 | ||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
As a diagnostic tool, the LockManager::dump() function, when invoked through an attached debugger, logs a list of acquired and enqueued locks. The lockInfo command also performs a similar function through the shell/client interface, but with additional information on the Client/OperationContext objects associated with each granted/pending lock request. Since the LockManager::dump() function is used more widely as part of the shutdown procedure for stalled test runs in our CI system, it would improve diagnostics to also include the Client/OpCtx information in the logs() when dumping the lock manager's internal state through the debugger. Sample output:
Sample output with command information:
|
| Comments |
| Comment by Benety Goh [ 29/Jan/20 ] | ||||||
|
Due to | ||||||
| Comment by Githook User [ 29/Jan/20 ] | ||||||
|
Author: {'username': 'benety', 'name': 'Benety Goh', 'email': 'benety@mongodb.com'}Message: Revert " This reverts commit 41981ad8d67b3fc95da21506751cc5d284e724e1. | ||||||
| Comment by Benety Goh [ 22/Jan/20 ] | ||||||
|
Linking to | ||||||
| Comment by Githook User [ 15/Jan/20 ] | ||||||
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: (cherry picked from commit 1245770e0ac12d09bceec097fcf66865b040a463) | ||||||
| Comment by Githook User [ 15/Jan/20 ] | ||||||
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: (cherry picked from commit 34719559a9ec4bd494a59d269d227d06b086affb) | ||||||
| Comment by Githook User [ 15/Jan/20 ] | ||||||
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: (cherry picked from commit cf4c944977a348494d81eeaf7eddb96ef0457876) | ||||||
| Comment by Githook User [ 15/Jan/20 ] | ||||||
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: (partially cherry picked from commit 990b2ef30d7b8fa4db6af6d79da80e3664df9c21) | ||||||
| Comment by Githook User [ 15/Jan/20 ] | ||||||
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: (cherry picked from commit 078f31ba54768fa5945c122257e740f1196defe8) | ||||||
| Comment by Githook User [ 09/Jan/20 ] | ||||||
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: (cherry picked from commit 1245770e0ac12d09bceec097fcf66865b040a463) | ||||||
| Comment by Githook User [ 08/Jan/20 ] | ||||||
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: (cherry picked from commit 34719559a9ec4bd494a59d269d227d06b086affb) | ||||||
| Comment by Githook User [ 08/Jan/20 ] | ||||||
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: (cherry picked from commit cf4c944977a348494d81eeaf7eddb96ef0457876) | ||||||
| Comment by Githook User [ 08/Jan/20 ] | ||||||
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: (partially cherry picked from commit 990b2ef30d7b8fa4db6af6d79da80e3664df9c21) | ||||||
| Comment by Githook User [ 08/Jan/20 ] | ||||||
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: (cherry picked from commit 078f31ba54768fa5945c122257e740f1196defe8) | ||||||
| Comment by Benety Goh [ 10/Dec/19 ] | ||||||
|
bartle, the changes in this ticket will surface the command invocation information to the lock manager output. We still have to verify that the "lsid" and "txnNumber" fields mentioned in | ||||||
| Comment by Benety Goh [ 10/Dec/19 ] | ||||||
|
This was originally done to support some 4.4 development work. The changes themselves don't seem that controversial. I've put in the request to start the back port process. | ||||||
| Comment by David Bartley [ 07/Dec/19 ] | ||||||
|
Oh, whoops, meant | ||||||
| Comment by David Bartley [ 07/Dec/19 ] | ||||||
|
Would it be possible to backport this to 4.2 and 4.0? We're trying to debug a deadlock (see
| ||||||
| Comment by Githook User [ 11/Oct/19 ] | ||||||
|
Author: {'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}Message: | ||||||
| Comment by Githook User [ 11/Oct/19 ] | ||||||
|
Author: {'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}Message: | ||||||
| Comment by Githook User [ 11/Oct/19 ] | ||||||
|
Author: {'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}Message: | ||||||
| Comment by Githook User [ 11/Oct/19 ] | ||||||
|
Author: {'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}Message: | ||||||
| Comment by Benety Goh [ 09/Oct/19 ] | ||||||
|
The lockInfo command was added in |