[SERVER-43924] remove Error Status construction from IndexBuildsCoordinator Created: 09/Oct/19  Updated: 29/Oct/23  Resolved: 10/Oct/19

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Task Priority: Major - P3
Reporter: Benety Goh Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-42962 remove Error Status construction for ... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2019-10-21
Participants:

 Description   

https://github.com/mongodb/mongo/blob/906ac3ca78d352df2d0dd45350195251efe0dea1/src/mongo/db/index_builds_coordinator.cpp#L833

This line of code is hinted as Cold to the compiler, which can affect branch prediction and performance. We should refactor to remove this line or replace it with one that uses Status::OK, which is not hinted as Cold.



 Comments   
Comment by Githook User [ 09/Oct/19 ]

Author:

{'username': 'benety', 'email': 'benety@mongodb.com', 'name': 'Benety Goh'}

Message: SERVER-43924 Remove construction of Status with ErrorCodes::Error in IndexBuildsCoordinator
Branch: master
https://github.com/mongodb/mongo/commit/b19059886cbd5fe55df8c7f87335a5d1112c9206

Comment by Benety Goh [ 09/Oct/19 ]

Code review url: http://mongodbcr.appspot.com/491180025

Generated at Thu Feb 08 05:04:29 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.