[SERVER-43936] Replace cpplint.py Created: 10/Oct/19 Updated: 29/Oct/23 Resolved: 29/Oct/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.1 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | Mark Benvenuto |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Sprint: | Security 2019-11-04 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Description |
|
A recent analysis of lint results showed that the cpplint.py portion of our lint task finds only three classes of issues:
What cpplint.py isn't doing is telling us anything interesting about C++. And, now that we have clang-tidy available per We should write a new tool that can live in the same ecosystem as clang-format and pylint that enforces only the last two items above. It will need to honor NOLINT I expect. Later, we should extend clang-tidy to enforce the rules that we want. |
| Comments |
| Comment by Mark Benvenuto [ 29/Oct/19 ] |
|
Removed in https://github.com/mongodb/mongo/commit/1e23641536f0b2e3632e11e40e35bf017b4f5e64 |
| Comment by Githook User [ 25/Oct/19 ] |
|
Author: {'name': 'Mark Benvenuto', 'username': 'markbenvenuto', 'email': 'mark.benvenuto@mongodb.com'}Message: |
| Comment by Githook User [ 25/Oct/19 ] |
|
Author: {'username': 'markbenvenuto', 'email': 'mark.benvenuto@mongodb.com', 'name': 'Mark Benvenuto'}Message: |