[SERVER-43987] Require predicates with OperationContext::waitForConditionOrInterrupt() Created: 14/Oct/19  Updated: 29/Oct/23  Resolved: 18/Oct/19

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.3.1, 4.2.2

Type: Improvement Priority: Major - P3
Reporter: Benjamin Caimano (Inactive) Assignee: Benjamin Caimano (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
is depended on by SERVER-42967 Add DiagnosticInfo hooks into Interru... Closed
Problem/Incident
causes SERVER-72087 Avoid recording flow control wait tim... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.2
Sprint: Service Arch 2019-10-21
Participants:

 Description   

There are a select few places where we use OperationContext::waitForConditionOrInterrupt() without predicates. I'd like all invocations to use predicates. It is i) easier to reason about for devs, ii) simpler to phrase as an API set, iii) empowers more sophisticated behaviors within Interruptibles.



 Comments   
Comment by Githook User [ 12/Nov/19 ]

Author:

{'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com', 'name': 'Ben Caimano'}

Message: SERVER-43987 Require predicates with OperationContext::waitForConditionOrInterrupt()

This commit also incoroporates parts of SERVER-44086 for backporting to
v4.2.
Branch: v4.2
https://github.com/mongodb/mongo/commit/5ecb2429a23af0ebf4af60d21e3b670a3045f563

Comment by Githook User [ 17/Oct/19 ]

Author:

{'name': 'Ben Caimano', 'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com'}

Message: SERVER-43987 Require predicates with OperationContext::waitForConditionOrInterrupt()
Branch: master
https://github.com/mongodb/mongo/commit/27ed83ca30107c8e39417ba1dfed5ec0dd8b859d

Generated at Thu Feb 08 05:04:41 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.