[SERVER-44025] Ensure that isNamedCode variable template specializations has internal linkage Created: 15/Oct/19 Updated: 29/Oct/23 Resolved: 17/Oct/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.1, 4.2.2 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Spencer Jackson | Assignee: | Spencer Jackson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Operating System: | ALL | ||||||||||||
| Backport Requested: |
v4.2, v4.0
|
||||||||||||
| Sprint: | Security 2019-10-21 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
Server artefacts compiled with Clang 9 fail to link, due to duplicate definitions of isNamedCode specializations in multiple object files. Per Clang's defect report overview, Clang 9 implements a fix for DR 2387: "Linkage of const-qualified variable template". It appears that variable template specializations now have external linkage unless explicitly marked inline. To fix compile on Clang 9, we should mark isNamedCode as inline. |
| Comments |
| Comment by Githook User [ 19/Nov/19 ] |
|
Author: {'username': 'markbenvenuto', 'email': 'mark.benvenuto@mongodb.com', 'name': 'Mark Benvenuto'}Message: (cherry picked from commit 9c6751b9765d269b667324bb2efe1ca76a916d20) |
| Comment by Githook User [ 17/Oct/19 ] |
|
Author: {'name': 'Spencer Jackson', 'username': 'spencerjackson', 'email': 'spencer.jackson@mongodb.com'}Message: |
| Comment by Spencer Jackson [ 15/Oct/19 ] |
|
Evgn: https://evergreen.mongodb.com/version/5da76f7ee3c33146eaf8c762 |