[SERVER-44129] Consolidate unowned and owned CollatorInterface's in ExpressionContext Created: 21/Oct/19  Updated: 27/Oct/23  Resolved: 03/Mar/20

Status: Closed
Project: Core Server
Component/s: Aggregation Framework
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Nicholas Zolnierz Assignee: Backlog - Query Team (Inactive)
Resolution: Gone away Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-45406 Provide ExpressionContext in PlanStag... Closed
Assigned Teams:
Query
Participants:

 Description   

As far as I can tell, the distinction exists because there are certain commands which require an ExpressionContext but manage a unique_ptr to the resolved collator on their own. This is confusing especially to new engineers, since its not obvious which one is valid and when.

As part of the review for SERVER-43844, a couple of ideas involved holding by intrusive_ptr or always cloning the collator even if its "owned" elsewhere.



 Comments   
Comment by David Storch [ 03/Mar/20 ]

This was done as part of SERVER-45406. Closing as "Gone Away".

Comment by David Storch [ 27/Feb/20 ]

ian.boros is working on this improvement as part of SERVER-45406. I'm going to flag this for triage so that we remember to close this ticket once Ian's work lands.

Generated at Thu Feb 08 05:05:06 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.