[SERVER-44147] Synchronize buildscripts/icecc_create_env with upstream Created: 22/Oct/19 Updated: 09/Dec/19 Resolved: 03/Dec/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Benjamin Caimano (Inactive) | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Sprint: | Dev Platform 2019-12-02, Dev Platform 2019-12-16 | ||||||||
| Participants: | |||||||||
| Description |
|
buildscripts/icecc_create_env has deviated from upstream at least in the use of temp directories if not in other ways. The upstream version seems to have been in active development since 2017. While we may not be able to mirror the script wholesale, we should at least evaluate differences. |
| Comments |
| Comment by Andrew Morrow (Inactive) [ 03/Dec/19 ] |
|
After much discussion, mathew.robinson and I decided that the only safe course of action right now was to leave the vendored icecc_create_env unmodified. We will revisit this as part of the v4 toolchain project and evaluate whether vendoring icecream into the toolchain is the right thing to do. |
| Comment by Andrew Morrow (Inactive) [ 27/Nov/19 ] |
|
I think this might be an argument in favor of adding icecream to the toolchain build. That way, you could either point to it directly with ICECC_CREATE_ENV on the command line, and we could also put it in the various toolchain variables files. |