[SERVER-44183] Failure to listen on an asio socket should be fatal Created: 23/Oct/19  Updated: 29/Oct/23  Resolved: 28/Oct/19

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 3.6.15, 4.3.1, 4.2.2, 4.0.14

Type: Bug Priority: Major - P3
Reporter: Benjamin Caimano (Inactive) Assignee: Benjamin Caimano (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.2, v4.0, v3.6
Sprint: Service Arch 2019-11-04
Participants:
Case:

 Description   

We use the throwing form of listen() with our asio sockets. We should use the nothrow version (since asio pipes error_code lvalues through anyway) and fassert on failure.



 Comments   
Comment by Githook User [ 28/Oct/19 ]

Author:

{'name': 'Ben Caimano', 'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com'}

Message: SERVER-44183 Failure to listen on an asio socket should be fatal
Branch: master
https://github.com/mongodb/mongo/commit/7330f4ba24e7218bf2dcbbff450039c81c74077f

Comment by Githook User [ 28/Oct/19 ]

Author:

{'name': 'Ben Caimano', 'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com'}

Message: SERVER-44183 Failure to listen on an asio socket should be fatal
Branch: v4.2
https://github.com/mongodb/mongo/commit/b2fcdb98a5866a1c12b26f3db728b815ad61008a

Comment by Githook User [ 28/Oct/19 ]

Author:

{'name': 'Ben Caimano', 'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com'}

Message: SERVER-44183 Failure to listen on an asio socket should be fatal
Branch: v4.0
https://github.com/mongodb/mongo/commit/7a2609a73641a5091d1f083ed1175c1bef7364c6

Comment by Githook User [ 28/Oct/19 ]

Author:

{'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com', 'name': 'Ben Caimano'}

Message: SERVER-44183 Failure to listen on an asio socket should be fatal
Branch: v3.6
https://github.com/mongodb/mongo/commit/780d4570b213baccbed9fb67b828fb944785c5d4

Comment by Benjamin Caimano (Inactive) [ 23/Oct/19 ]

Code Review

Generated at Thu Feb 08 05:05:15 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.