[SERVER-44185] Convert keyStringAssert() and keyStringAsserted() into a macro to avoid evaluating parameters early Created: 23/Oct/19  Updated: 29/Oct/23  Resolved: 25/Oct/19

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Improvement Priority: Major - P3
Reporter: Gregory Wlodarek Assignee: Gregory Wlodarek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Related
related to SERVER-42414 Improve KeyString invalid format erro... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2019-11-04
Participants:
Linked BF Score: 0

 Description   

SERVER-42414 caused a performance regression due to the newly added keyStringAssert() function. The root cause of this regression was that the boolean parameter expr in the function was being evaluated before entering the function, which was previously an explicit MONGO_unlikely condition in the uassert macro.



 Comments   
Comment by Githook User [ 25/Oct/19 ]

Author:

{'username': 'GWlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'name': 'Gregory Wlodarek'}

Message: SERVER-44185 Convert keyStringAssert() and keyStringAsserted() into a macro to avoid evaluating parameters early
Branch: master
https://github.com/mongodb/mongo/commit/232a30488cd016439ab6455193c1f8424014cea2

Generated at Thu Feb 08 05:05:16 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.