[SERVER-44272] Resync data on replSetSyncFrom during initial sync Created: 27/Oct/19 Updated: 29/Oct/23 Resolved: 13/Mar/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.0-rc0, 4.7.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Siyuan Zhou | Assignee: | Jason Chan |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | former-quick-wins | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||||||||||||||
| Backport Requested: |
v4.4
|
||||||||||||||||||||||||||||||||||||||||
| Sprint: | Repl 2020-02-10, Repl 2020-03-09, Repl 2020-03-23 | ||||||||||||||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||||||||||||||
| Description |
|
Initial sync doesn't allow changing sync source because the data isn't consistent during initial sync, however it's reasonable to allow changing sync source and restarting initial sync on replSetSyncFrom command, if the specified sync source is different from the current one. Currently the replSetSyncFrom supports initiating a resync while in the middle of an initial sync, but the resync implementation is known to be broken in subtle ways. We should investigate whether these bugs still exist and if so, redesign the implementation. The command should only restart the active initial sync attempt, not go back into initial sync if initial sync is complete |
| Comments |
| Comment by Githook User [ 26/Mar/20 ] |
|
Author: {'email': 'jason.chan@10gen.com', 'name': 'Jason Chan', 'username': 'jasonjhchan'}Message: (cherry picked from commit 1cb592ac1b74e8f62d2ded5959945d626483402c) |
| Comment by Jason Chan [ 13/Mar/20 ] |
|
siyuan.zhou Yup, |
| Comment by Siyuan Zhou [ 13/Mar/20 ] |
|
jason.chan, since resync in initial sync is the last call of resyncData. Can we also remove it in a follow-up commit? |
| Comment by Githook User [ 13/Mar/20 ] |
|
Author: {'username': 'jasonjhchan', 'name': 'Jason Chan', 'email': 'jason.chan@10gen.com'}Message: |