[SERVER-44338] Validate commit message as part of commit queue process Created: 31/Oct/19  Updated: 29/Oct/23  Resolved: 09/Dec/19

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 4.3.3

Type: Improvement Priority: Major - P3
Reporter: David Bradford (Inactive) Assignee: James O'Leary
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: DAG 2019-12-16
Participants:
Story Points: 2

 Description   

As part of the migration to commit queue, pre-commit git hooks are no longer run. One of the hooks that was run validated that the commit message conformed to certain rules. With EVG-6445, we should be able to create a task that runs as part of the commit queue to validate the commit message.


As a server engineer,
I want a commit queue check to validate the commit message
So that I don't know accidentally commit with a bad message.


AC:

  • A commit queue task is run that fails if the commit has an invalid message.


 Comments   
Comment by Githook User [ 09/Dec/19 ]

Author:

{'email': 'jim.oleary@mongodb.com', 'name': "Jim O'Leary", 'username': 'jimmongo'}

Message: SERVER-44338 validate commit message usability
Branch: master
https://github.com/mongodb/mongo/commit/1f5591c7a060cc9a048462b618e2ca7c767036c3

Comment by James O'Leary [ 06/Dec/19 ]

Extra feature request: make the script work like the following command if no parameters are provided:

$ buildscripts/validate_commit_message.py "$(git show -1 -s --format=%s )"

Comment by Githook User [ 06/Dec/19 ]

Author:

{'email': 'jim.oleary@mongodb.com', 'name': "Jim O'Leary", 'username': 'jimmongo'}

Message: SERVER-44338 validate commit message
Branch: master
https://github.com/mongodb/mongo/commit/0ccd8da6ee358249469edf0b367ff9c5cc99c24c

Generated at Thu Feb 08 05:05:43 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.