[SERVER-44528] kill_with_prepare_conflicts_during_step_up needs to wait on failpoint properly Created: 08/Nov/19  Updated: 29/Oct/23  Resolved: 15/Nov/19

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.3.2

Type: Bug Priority: Major - P3
Reporter: Matthew Russotto Assignee: Matthew Russotto
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Repl 2019-11-18
Participants:
Linked BF Score: 19

 Description   

kill_with_prepare_conflicts_during_step_up configures a failpoint, then runs code which hits it, then clears the global log assuming this will clear the failpoint, then waits for the failpoint to be hit again. This doesn't work with the new failpoint helper which isn't based on the global log, so we don't actually wait for the second time the failpoint is hit.

I believe this can be fixed just by moving the configureFailPoint down to where we currently clear the global log.



 Comments   
Comment by Githook User [ 15/Nov/19 ]

Author:

{'username': 'mtrussotto', 'email': 'matthew.russotto@mongodb.com', 'name': 'Matthew Russotto'}

Message: SERVER-44528 kill_with_prepare_conflicts_during_step_up needs to wait on failpoint properly
Branch: master
https://github.com/mongodb/mongo/commit/6ff10758ce75b2ecc39d5d71322479b338031cf8

Generated at Thu Feb 08 05:06:14 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.