[SERVER-44557] Set an explicit default for the SCons MSVC_VERSION flag Created: 11/Nov/19  Updated: 29/Oct/23  Resolved: 08/Dec/19

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 4.2.3, 4.3.3

Type: Improvement Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Andrew Morrow (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.2, v4.0, v3.6
Sprint: Dev Platform 2019-11-18, Dev Platform 2019-12-02, Dev Platform 2019-12-16
Participants:

 Description   

SCons, by default, opts for the newest MSVC version on the system. There is a SCons Variable that you can use to specify which one you want. We should arrange things so that on each stable branch, the value of MSVC_VERSION defaults to the one correct version of MSVC for that branch.



 Comments   
Comment by Githook User [ 16/Dec/19 ]

Author:

{'name': 'Andrew Morrow', 'email': 'andrew.morrow@10gen.com'}

Message: SERVER-44557 Set the default for MSVC_VERSION to VS2017

(cherry picked from commit 7c428b6fba15eb2058d52430b8d2c5f4df45d7ad)
Branch: v4.2
https://github.com/mongodb/mongo/commit/da7f08a649e84846162a2a2276938cd61c90f017

Comment by Githook User [ 16/Dec/19 ]

Author:

{'name': 'Andrew Morrow', 'email': 'andrew.morrow@10gen.com'}

Message: SERVER-44557 Use values from new vcredist tool for installing redistributables

(cherry picked from commit bff54971e5f77ba1127ed3c993cbfc77ae9b0d04)
Branch: v4.2
https://github.com/10gen/mongo-enterprise-modules/commit/27169ab52c0eb703059eed2216fc185505f8387a

Comment by Andrew Morrow (Inactive) [ 08/Dec/19 ]

The further we backport this, the more builds we can consolidate on to a future builder that has multiple VS versions installed. So, let's plan for all the way back to 3.6.

Comment by Githook User [ 08/Dec/19 ]

Author:

{'email': 'andrew.morrow@10gen.com', 'name': 'Andrew Morrow'}

Message: SERVER-44557 Set the default for MSVC_VERSION to VS2017
Branch: master
https://github.com/mongodb/mongo/commit/7c428b6fba15eb2058d52430b8d2c5f4df45d7ad

Comment by Githook User [ 08/Dec/19 ]

Author:

{'name': 'Andrew Morrow', 'email': 'andrew.morrow@10gen.com'}

Message: SERVER-44557 Use values from new vcredist tool for installing redistributables
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/bff54971e5f77ba1127ed3c993cbfc77ae9b0d04

Comment by Mark Benvenuto [ 11/Nov/19 ]

It sounds good to me.

Comment by Henrik Edin [ 11/Nov/19 ]

Totally OK with me. I already have it in my local build scripts.

Generated at Thu Feb 08 05:06:18 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.