[SERVER-4459] remove "using boost namespace" from goodies.h Created: 08/Dec/11  Updated: 11/Jul/16  Resolved: 12/Dec/11

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 2.1.0

Type: Improvement Priority: Minor - P4
Reporter: Eric Milkie Assignee: Eric Milkie
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Participants:

 Description   

Probably a bad idea to have "using namespace boost;" in a common header. The boost namespace is enormous and has a potential for name collisions and confusion. Maybe we can tighten up the scope to just common things we use like scoped/shared pointer, etc.



 Comments   
Comment by auto [ 09/Dec/11 ]

Author:

{u'login': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}

Message: SERVER-4459 fix windows build: prior() is in boost::
Branch: master
https://github.com/mongodb/mongo/commit/48ff079ebee28af28f5a82973012ee37bdb42624

Comment by auto [ 08/Dec/11 ]

Author:

{u'login': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}

Message: SERVER-4459 move shared_mutex so that we only "using" it on non-Windows and only after including the header file with its implementation
Branch: master
https://github.com/mongodb/mongo/commit/789f87e9ccfcba148aa4345f17befca6e49d847d

Comment by Eric Milkie [ 08/Dec/11 ]

Needs a few more fixes.

Comment by auto [ 08/Dec/11 ]

Author:

{u'login': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}

Message: SERVER-4459 tighten up namespace pollution. importing all of boost in a global header isn't nice.
Branch: master
https://github.com/mongodb/mongo/commit/7e0586bd65a148146a7254d47e40893b1670613d

Generated at Thu Feb 08 03:06:02 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.