[SERVER-44642] Verify that implementation of cross-database $out attaches writeConcern appropriately in sharded environments Created: 14/Nov/19  Updated: 29/Oct/23  Resolved: 13/Mar/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.4.0-rc0, 4.7.0

Type: Task Priority: Major - P3
Reporter: Ted Tuckman Assignee: Svilen Mihaylov (Inactive)
Resolution: Fixed Votes: 0
Labels: neweng, qopt-team
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Duplicate
duplicates SERVER-45968 Test behavior of $merge/$out on secon... Closed
Related
is related to SERVER-44979 MongoInterfaceShardServer must check ... Closed
is related to SERVER-44897 Remove DBDirectClient from process_in... Closed
Backwards Compatibility: Minor Change
Backport Requested:
v4.4
Sprint: Query 2020-03-09, Query 2020-03-23
Participants:

 Description   

The implementation of $out involves calling several sub-routines like creating a temporary collection, getting the index and collection options, doing the inserts, and renaming the collection into place. In SERVER-45968 we verified these work correctly in a replica set deployment, but we have separate implementations of these helpers on a shard server, which should similarly attach writeConcern.

SERVER-45968 wrote a javascript integration test which verifies the aggregate and $out machinery above this layer will propagate the error appropriately to the client. As such, it's probably sufficient to just write unit tests to verify the remote requests all have the appropriate writeConcern attached. Another javascript test would also be acceptable though if unit testing proves difficult.



 Comments   
Comment by Githook User [ 17/Mar/20 ]

Author:

{'email': 'svilen.mihaylov@mongodb.com', 'name': 'Svilen Mihaylov', 'username': 'smihaylov-mongodb'}

Message: SERVER-44642 Verify that implementation of cross-database $out attaches writeConcern appropriately in sharded environments
Branch: v4.4
https://github.com/mongodb/mongo/commit/70345ec48ccbfd3e4a6c357ec862b573b31f5f52

Comment by Githook User [ 13/Mar/20 ]

Author:

{'name': 'Svilen Mihaylov', 'username': 'smihaylov-mongodb', 'email': 'svilen.mihaylov@mongodb.com'}

Message: SERVER-44642 Verify that implementation of cross-database $out attaches writeConcern appropriately in sharded environments
Branch: master
https://github.com/mongodb/mongo/commit/ffd57e8bc049d4d188e667fa4d6c9f956b91ee0b

Comment by Ted Tuckman [ 02/Dec/19 ]

Created SERVER-44897 for the createIndexes part of the ticket

Comment by Nicholas Zolnierz [ 26/Nov/19 ]

benety.goh has a patch for removing the DBDirectClient usage in createIndexes: https://evergreen.mongodb.com/version/5dd598955623436121e00d6f

May make sense to split that piece off.

Comment by Ted Tuckman [ 14/Nov/19 ]

esha.maharishi

Generated at Thu Feb 08 05:06:33 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.