[SERVER-44746] Fix LatchAnalyzerTest Created: 20/Nov/19 Updated: 29/Oct/23 Resolved: 02/Dec/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.3 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Benjamin Caimano (Inactive) | Assignee: | Rahul Sundararaman (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Sprint: | Service Arch 2019-12-02, Service Arch 2019-12-16 | ||||
| Participants: | |||||
| Linked BF Score: | 0 | ||||
| Description |
|
It seems that Windows doesn't allow us to dtor a locked mutex (that behavior is in fact UB). This implies that failures during lock could be hidden by consequential failures during unlock. We should:
As an example for LatchAnalyzerTest::AddValidWasAbsent, we would:
|
| Comments |
| Comment by Githook User [ 03/Mar/20 ] |
|
Author: {'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}Message: This commit also backports:
|
| Comment by Githook User [ 02/Dec/19 ] |
|
Author: {'email': 'rahul.sundararaman@mongodb.com', 'name': 'Rahul Sundararaman'}Message: |
| Comment by Githook User [ 20/Nov/19 ] |
|
Author: {'name': 'Ben Caimano', 'username': 'bcaimano', 'email': 'ben.caimano@mongodb.com'}Message: |